Skip to content

Fix NoneType error of outputs #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsliuustc0106 merged 2 commits into from
Apr 17, 2026
+1 −0
Merged

Fix NoneType error of outputs #2315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c34da1a
Fix NoneType error of outputs
Mar 30, 2026
3ff483e
Merge branch 'main' into none_stream_fix_with_log
hsliuustc0106 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vllm_omni/entrypoints/openai/serving_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,6 +1579,7 @@ async def chat_completion_full_generator(
role,
reasoning_parser,
)
final_res = omni_outputs.request_output
Copy link
Copy Markdown
Collaborator

@lishunyang12 lishunyang12 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good — this was the missing assignment. But the same final_res is used in the logging block ~40 lines below without a None check, so audio/image-only requests still crash.

Copy link
Copy Markdown
Contributor Author

@QiuMike QiuMike Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audio/image the output_text should be "", and will not crash, anything wrong?

elif omni_outputs.final_output_type == "audio":
choices_data = self._create_audio_choice(omni_outputs, role, request, stream=False)
elif omni_outputs.final_output_type == "image":
Expand Down
Loading