[feature] add TeaCache support for OmniGen2#2257
Conversation
|
A recent PR changed the diffusion features docs strucure. Pls PTAL #1928. |
Noted, thanks! |
Signed-off-by: zhou zhuoxin <zhouzhuoxin1508@outlook.com>
zzhuoxin1508
force-pushed
the
omnigen2-teacache
branch
from
3a576a0 to
fa95c87
Compare
Signed-off-by: zhou zhuoxin <zhouzhuoxin1508@outlook.com>
lishunyang12
left a comment
lishunyang12
left a comment
There was a problem hiding this comment.
left a couple comments
| @@ -37,6 +37,15 @@ | |||
| # Bagel transformer coefficients | |||
| # Using Qwen's coefficients as reasonable default given shared architecture | |||
| "Bagel": [1.33313129e06, -1.68644226e05, 7.95050740e03, -1.63747873e02, 1.26352397e00], | |||
There was a problem hiding this comment.
The test plan says results will be provided "as soon as possible" — are these coefficients validated at all yet? Shipping untuned polynomial coefficients could silently degrade output quality. Would be good to at least confirm basic generation quality before merging.
|
Sorry for the delay.Right now TeaCache only supports 2-branch CFG ,but omnigen2 is 3-branch . I've filed this as issue#2371. So these coefficients only cover the 2-branch path; fuller validation depends on #2371. @lishunyang12 |
Signed-off-by: zhou zhuoxin <zhouzhuoxin1508@outlook.com>
Signed-off-by: zhou zhuoxin <zhouzhuoxin1508@outlook.com>
3 participants
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR implements TeaCache support for OmniGen2
Test Plan
I will provide the detailed benchmark and test results as soon as possible.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)