[BUG FIX]: prevent EngineCore crash when Qwen TTS Base task is missing ref_text#2203
Merged
linyueqian merged 1 commit intoApr 11, 2026
Merged
Conversation
Collaborator
|
Do we need to add test cases for this scenario? @linyueqian |
Collaborator
yes, it would be great. |
Collaborator
|
fix pre-commit please |
Collaborator
|
fix dco please |
152f1b6 to
1316136
Compare
lishunyang12
reviewed
Apr 2, 2026
Collaborator
lishunyang12
left a comment
There was a problem hiding this comment.
left a minor comment, otherwise looks good
lishunyang12
reviewed
Apr 2, 2026
5 tasks
Collaborator
|
fix ci |
linyueqian
added a commit
to teith/vllm-omni
that referenced
this pull request
Apr 11, 2026
Parametrized test covering ref_text=None, "", and whitespace-only to ensure the serving layer returns HTTP 400 instead of letting a malformed request crash the EngineCore. Regression test for vllm-project#2203 Signed-off-by: Yueqian Lin <yueqian.lin@outlook.com>
2eabe77 to
85325d8
Compare
… TTS Base task A single malformed request to /v1/audio/speech with task_type=Base and no ref_text kills the entire EngineCore. All subsequent requests fail with EngineDeadError. Root cause: _build_prompt_embeds() raises ValueError when ref_text is missing in ICL mode. vLLM v1 treats any worker exception as fatal. Fix: - serving_speech.py: validate ref_text presence for Base task before the request reaches the engine (returns HTTP 400) - qwen3_tts_talker.py: fall back to x-vector-only mode instead of raising, matching the existing non-ICL codepath Also adds a parametrized regression test covering ref_text=None, "", and whitespace-only inputs. Signed-off-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com>
85325d8 to
a0cd54c
Compare
daixinning
pushed a commit
to daixinning/vllm-omni
that referenced
this pull request
Apr 13, 2026
…g ref_text (vllm-project#2203) Signed-off-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com> Co-authored-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com>
lengrongfu
pushed a commit
to lengrongfu/vllm-omni
that referenced
this pull request
May 1, 2026
…g ref_text (vllm-project#2203) Signed-off-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com> Co-authored-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com>
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
…g ref_text (vllm-project#2203) Signed-off-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com> Co-authored-by: Yueqian Lin <70319226+linyueqian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single malformed request to
/v1/audio/speechwithtask_type=Baseand noref_textkills the entireEngineCore. All subsequent requests — including valid ones — fail withEngineDeadError.Reproduce:
serve:
vllm-omni serve Qwen/Qwen3-TTS-12Hz-1.7B-Base --omni --trust-remote-code --host 0.0.0.0 --port 8000 --enforce-eagerRoot cause:
_build_prompt_embeds()raisesValueErrorwhenref_textis missing in ICL mode. vLLM v1 treats any worker exception as fatal.Fix:
serving_speech.py: validateref_textpresence for Base task before the request reaches the engine (returns HTTP 400)qwen3_tts_talker.py: fall back tox-vector-onlymode instead of raising, matching the existing non-ICL codepath (protects offline inference and other entrypoints)