[Perf] Qwen-Image Nightly Performance CI Improvement#2111
Merged
Conversation
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Made-with: Cursor Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Made-with: Cursor Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 477702ab2c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
congw729
reviewed
Mar 24, 2026
wtomin
commented
Mar 24, 2026
Made-with: Cursor Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Collaborator
|
Please rebase to the latest origin/main branch and the Doc failed builds will be resolved. |
5 tasks
zhangj1an
pushed a commit
to zhangj1an/vllm-omni
that referenced
this pull request
Mar 26, 2026
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
zhangj1an
pushed a commit
to zhangj1an/vllm-omni
that referenced
this pull request
Mar 26, 2026
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
lengrongfu
pushed a commit
to lengrongfu/vllm-omni
that referenced
this pull request
May 1, 2026
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Replaced all {"$ref": "benchmark_params.json"} references in test_qwen_image_sglang_diffusion.json and test_qwen_image_vllm_omni.json with the full inline parameter arrays (3 benchmark cases each: 512x512_steps20, 1536x1536_steps35, mixed_resolution).
Deleted tests/perf/tests/benchmark_params.json.
Extracted throughput_qps, latency_p99, peak_memory_mb_max, peak_memory_mb_mean from results.json for all 9 combinations (3 test cases × 3 benchmark params) and wrote them into the baseline blocks of test_qwen_image_vllm_omni.json.
Used git mv to properly rename all three tracked files:
tests/perf/scripts/run_diffusion_benchmark.py → tests/dfx/perf/scripts/
tests/perf/tests/test_qwen_image_sglang_diffusion.json → tests/dfx/perf/tests/
tests/perf/tests/test_qwen_image_vllm_omni.json → tests/dfx/perf/tests/
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)