[Test] L4 complete diffusion feature test for LongCat Image Edit models#2035
Conversation
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d89dacc452
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
lishunyang12
left a comment
There was a problem hiding this comment.
Left a few comments. Main concern is the gap between what the docstring claims and what's actually tested.
|
@lcukyfuture PTAL |
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d89dacc452
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
… fixed target area Signed-off-by: NumberWan <wantszkin2003@gmail.com>
bc75fd6 to
968c59c
Compare
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
Signed-off-by: NumberWan <wantszkin2003@gmail.com>
|
@congw729 @yenuo26 @lcukyfuture @fhfuih @wtomin PTAL All the local test and CI test has been passed. |
fhfuih
left a comment
There was a problem hiding this comment.
LGTM. It is not a high-priority model, so these test cases shall be good enough for now.
…ls (vllm-project#2035) Signed-off-by: NumberWan <wantszkin2003@gmail.com>
…ls (vllm-project#2035) Signed-off-by: NumberWan <wantszkin2003@gmail.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR adds an L4 diffusion feature expansion e2e test for LongCat-Image-Edit (
meituan-longcat/LongCat-Image-Edit), covering the recommended combination acceleration features for LongCat-Image-Edit.Tests are picked up by nightly:
test_*_expansion.py -m 'advanced_model and diffusion and H100'.The test is intended to be picked up by the L4 nightly diffusion pipeline described in RFC #1832.
Test Plan
The diffusion acceleration doc / RFC #1217 states that LongCat-Image-Edit supports the following features according the recommended combination:
Test Coverage for LongCat-Image-Edit (L4, online_serving)
New test file
tests/e2e/online_serving/test_longcat_image_edit_expansion.pyModel
meituan-longcat/LongCat-Image-EditCases
single_card_001--enable-cpu-offload(1 GPU)parallel_001--cache-backend cache_dit --ulysses-degree 2(2 GPUs)Test Result [Passed]
pytest tests/e2e/online_serving/test_longcat_image_edit_expansion.py --collect-only -m diffusionAdditional Test Result [Passed]
Command :
CI Test Result [Passed]
CI Successful in both 2 tests