-
Notifications
You must be signed in to change notification settings - Fork 1k
[Bugfix] Fix config misalignment between offline and online diffusion inference (Wan2.2, Qwen-Image series) #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
26a4e8d
b3b70a8
104d71c
bf2ddb0
735b2ca
dd4468c
ff62a1e
870963e
5414a42
e3dec54
2cd9f9f
172040a
0a86fc5
9b9c597
bda0f2d
3452ad3
9ab7c55
c32a78a
91afe27
9b783a6
cf286ec
3f2beee
140ef4a
979a890
63b1715
15c3eb1
f3c21ab
6026495
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -221,6 +221,7 @@ def execute_model(self, req: OmniDiffusionRequest) -> DiffusionOutput: | |
| not getattr(req, "skip_cache_refresh", False) | ||
| and self.cache_backend is not None | ||
| and self.cache_backend.is_enabled() | ||
| and req.sampling_params.num_inference_steps is not None | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new Useful? React with 👍 / 👎. |
||
| ): | ||
| self.cache_backend.refresh(self.pipeline, req.sampling_params.num_inference_steps) | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,8 +234,9 @@ class OmniDiffusionSamplingParams: | |
| step_index: int | None = None | ||
| boundary_ratio: float | None = None | ||
|
|
||
| # Scheduler parameters | ||
| num_inference_steps: int = 50 | ||
| # Scheduler parameters – ``None`` means "not explicitly set by the caller"; | ||
| # each pipeline's ``forward()`` decides its own model-specific default. | ||
| num_inference_steps: int | None = None | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Changing Useful? React with 👍 / 👎. |
||
| guidance_scale: float = 0.0 | ||
| guidance_scale_provided: bool = False | ||
| guidance_scale_2: float | None = None | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm