[Bugfix] NextStep cannot launch with offline example text_to_image.py#1947
Closed
fhfuih wants to merge 1 commit into
Closed
[Bugfix] NextStep cannot launch with offline example text_to_image.py#1947fhfuih wants to merge 1 commit into
fhfuih wants to merge 1 commit into
Conversation
Signed-off-by: Huang, Zeyu <11222265+fhfuih@users.noreply.github.com>
cd75c6f to
7c7ec07
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes offline NextStep example startup by ensuring OmniDiffusion selects the NextStep pipeline class even when model_class_name is pre-set by the offline script.
Changes:
- Use
od_config.model_class_nameas thepipeline_classformodel_type == "nextstep"when provided. - Preserve the existing default behavior (
NextStep11Pipeline) whenmodel_class_nameis not provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Author
|
Close as this file is deleted after #1908 . The offline entrypoint also uses async engine, which does not have this error any more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The offline example text_to_image.py script specially caters to NextStep model by setting
But in this case, it skips the real setup in OmniDiffusion.
Thus, it results in the following error
Note that this error is only about the offline inference mode (not AsyncOmniDuffusion).
Test Plan
Run the NextStep example snippet in the doc after this patch
Instead of showing the error above, it should run fine.
Test Result
Pass on my side. There is no CI test for NextStep for now.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)