Skip to content

[XPU] update bagel modeling to remove cuda hardcode, add xpu stage_config#1931

Merged
gcanlin merged 4 commits into
vllm-project:mainfrom
xuechendi:xpu_0.17_bagel_fix
Mar 19, 2026
Merged

[XPU] update bagel modeling to remove cuda hardcode, add xpu stage_config#1931
gcanlin merged 4 commits into
vllm-project:mainfrom
xuechendi:xpu_0.17_bagel_fix

Conversation

@xuechendi
Copy link
Copy Markdown
Contributor

@xuechendi xuechendi commented Mar 16, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Recent Bagel update introduced new cuda hard-code, this PR aimed to generalize the change to other platforms.
Meanwhile, add xpu stage_config

Test Plan

python /workspace/vllm-omni//examples/offline_inference/bagel/end2end.py --model ByteDance-Seed/BAGEL-7B-MoT --prompts "A cute cat" --modality text2img --steps 50 --cfg-text-scale 4.0 --cfg-img-scale 1.5 --seed 42 --output /workspace/vllm-ci/outputs/bagel_7b_mot_text2img

Test Result

image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
@xuechendi xuechendi force-pushed the xpu_0.17_bagel_fix branch from 8c41ef2 to 4099385 Compare March 16, 2026 19:35
@xuechendi
Copy link
Copy Markdown
Contributor Author

xuechendi commented Mar 17, 2026

@gcanlin , @hsliuustc0106 , may you take a review.

Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsliuustc0106 hsliuustc0106 added the ready label to trigger buildkite CI label Mar 18, 2026
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
@hsliuustc0106
Copy link
Copy Markdown
Collaborator

compare before and after this PR please

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
@xuechendi
Copy link
Copy Markdown
Contributor Author

@hsliuustc0106 , @gcanlin , I have rebased and updated according to #1908
Did local validation, output image is looking good as before

@gcanlin
Copy link
Copy Markdown
Collaborator

gcanlin commented Mar 19, 2026

@tjtanaa Could you help check this failed test on ROCm? It seems to be unrelated to this PR. https://buildkite.com/vllm/vllm-omni-amd-ci/builds/3362/steps/canvas?sid=019d0307-0ad3-4c30-9300-38e560ee071b&tab=output

@Gaohan123 Gaohan123 added this to the v0.18.0 milestone Mar 19, 2026
@gcanlin gcanlin merged commit ba5a66b into vllm-project:main Mar 19, 2026
7 checks passed
yiliu30 pushed a commit to yiliu30/vllm-omni-fork that referenced this pull request Mar 20, 2026
…nfig (vllm-project#1931)

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>

Signed-off-by: yiliu30 <yi4.liu@intel.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
…nfig (vllm-project#1931)

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants