Skip to content

Revert "Add online serving to Stable Audio Diffusion and introduce v1/audio/generate endpoint"#1789

Merged
hsliuustc0106 merged 1 commit into
mainfrom
revert-1255-er-stable-audio-online
Mar 10, 2026
Merged

Revert "Add online serving to Stable Audio Diffusion and introduce v1/audio/generate endpoint"#1789
hsliuustc0106 merged 1 commit into
mainfrom
revert-1255-er-stable-audio-online

Conversation

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

Reverts #1255

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5241588121

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +460 to 463
state.enable_server_load_tracking = getattr(args, "enable_server_load_tracking", False)
state.server_load_metrics = 0
logger.info("Pure diffusion API server initialized for model: %s", model_name)
return
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Initialize speech handler state in pure diffusion mode

This pure-diffusion initialization path returns without defining app.state.openai_serving_speech, but Omnispeech() later does a direct attribute read (request.app.state.openai_serving_speech) before the route-level None checks run. In pure diffusion deployments, calling /v1/audio/speech or /v1/audio/voices will therefore raise AttributeError and return a 500 instead of the expected “not supported” response; set openai_serving_speech = None in this branch (or switch Omnispeech to getattr) to preserve graceful handling.

Useful? React with 👍 / 👎.

@hsliuustc0106 hsliuustc0106 merged commit 4027534 into main Mar 10, 2026
4 checks passed
@ekagra-ranjan
Copy link
Copy Markdown
Contributor

ekagra-ranjan commented Mar 10, 2026

I am still in the process of seeing why it fails but I see a fix already: https://github.com/vllm-project/vllm-omni/pull/1771/changes

I think this works? The addition of _Unsupported might failed a CI but it highlighted the access of undefined variable serving_models.base_model_paths being accessed here. The fix PR adds the property here

@ekagra-ranjan
Copy link
Copy Markdown
Contributor

ekagra-ranjan commented Mar 10, 2026

I now understand why it happened and the fix.

The issue comes from _Unsupported being added to _DiffusionServingModels. It was added because earlier OpenAIServing accessing variables not defined in _DiffusionServingModels class with self.model_config = self.models.model_config which would fail even though its not used later on. Hence, I added _Unsupported so that such assignment dont fail during init but loudly if accessed. This failure during init still fails on vllm v0.16 but is fixed in vllm v0.17

However, there are other checks in vllm-omni that rely on hasattr() to see if _DiffusionServingModels has a variable and avoids using undefined variables. These checks fail because hasattr() calls getattr() and _Unsupported is truthy.

But now the recent vllm code assigns these variables in OpenAIServing using self.engine_client instead of self.models so the _Unsupported way can be safely removed. Will do and raise PR.

lishunyang12 pushed a commit to lishunyang12/vllm-omni that referenced this pull request Mar 11, 2026
…1/audio/generate` endpoint" (vllm-project#1789)

Signed-off-by: lishunyang <lishunyang12@163.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants