Revert "Add online serving to Stable Audio Diffusion and introduce v1/audio/generate endpoint"#1789
Conversation
…1/audio/…" This reverts commit 7a56049.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5241588121
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| state.enable_server_load_tracking = getattr(args, "enable_server_load_tracking", False) | ||
| state.server_load_metrics = 0 | ||
| logger.info("Pure diffusion API server initialized for model: %s", model_name) | ||
| return |
There was a problem hiding this comment.
Initialize speech handler state in pure diffusion mode
This pure-diffusion initialization path returns without defining app.state.openai_serving_speech, but Omnispeech() later does a direct attribute read (request.app.state.openai_serving_speech) before the route-level None checks run. In pure diffusion deployments, calling /v1/audio/speech or /v1/audio/voices will therefore raise AttributeError and return a 500 instead of the expected “not supported” response; set openai_serving_speech = None in this branch (or switch Omnispeech to getattr) to preserve graceful handling.
Useful? React with 👍 / 👎.
|
I am still in the process of seeing why it fails but I see a fix already: https://github.com/vllm-project/vllm-omni/pull/1771/changes I think this works? The addition of |
|
I now understand why it happened and the fix. The issue comes from However, there are other checks in But now the recent vllm code assigns these variables in |
…1/audio/generate` endpoint" (vllm-project#1789) Signed-off-by: lishunyang <lishunyang12@163.com>
…1/audio/generate` endpoint" (vllm-project#1789)
Reverts #1255