Skip to content

Add a base_model_paths property to _DiffusionServingModels.#1785

Open
sjuxax wants to merge 1 commit into
vllm-project:mainfrom
sjuxax:fix/base_model_paths_property
Open

Add a base_model_paths property to _DiffusionServingModels.#1785
sjuxax wants to merge 1 commit into
vllm-project:mainfrom
sjuxax:fix/base_model_paths_property

Conversation

@sjuxax
Copy link
Copy Markdown

@sjuxax sjuxax commented Mar 10, 2026

Purpose

Get a 500 Error without this.

Test Plan

Test committed to verify that _get_engine_and_models returns correctly when there's a single diffusion stage.

Test Result

Test good, 500 error gone.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

Get a 500 Error with pure diffusion models without this.

Signed-off-by: Jeff Cook <jeff@jeffcook.io>
@sjuxax sjuxax requested a review from hsliuustc0106 as a code owner March 10, 2026 11:15
@alex-jw-brooks
Copy link
Copy Markdown
Contributor

I think there is already a fix open for this one! #1771

Copy link
Copy Markdown
Collaborator

@lishunyang12 lishunyang12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — matches how upstream OpenAIServingModels exposes base_model_paths.

@lishunyang12
Copy link
Copy Markdown
Collaborator

I think there is already a fix open for this one! #1771

oh @sjuxax Please check if it is duplicated work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants