Skip to content

[Bugfix] Expose base_model_paths property in _DiffusionServingModels #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtomin merged 3 commits into from
Mar 11, 2026
Merged

[Bugfix] Expose base_model_paths property in _DiffusionServingModels #1771

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32a54d3
[Bugfix] Expose base_model_paths property in _DiffusionServingModels
RuixiangMa Mar 10, 2026
8cef62b
Merge branch 'main' into fixdiffusionServing
RuixiangMa Mar 11, 2026
a61033d
upd
RuixiangMa Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vllm_omni/entrypoints/openai/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ def __init__(self, base_model_paths: list[BaseModelPath]) -> None:
self._base_model_paths = base_model_paths
self.model_config = self._NullModelConfig()

@property
def base_model_paths(self) -> list[BaseModelPath]:
return self._base_model_paths

def __getattr__(self, name):

@lishunyang12 lishunyang12 Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the broader issue is that __getattr__ returns _Unsupported instead of raising AttributeError, so hasattr() always returns True for any attribute on this class. This fix is fine for the immediate bug, but any future hasattr() check will silently pass too.

"""Return a sentinel that raises NotImplementedError if called or
accessed, so any use of unsupported OpenAIServingModels features in
Expand Down