-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Bugfix] Suppress harmless repo_utils ERROR in stage workers for local model paths #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Lidang-Jiang
wants to merge
3
commits into
vllm-project:main
from
Lidang-Jiang:fix/suppress-repo-utils-error-in-stage-workers
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
69d235c
[Bugfix] Suppress harmless repo_utils ERROR in stage workers for loca…
Lidang-Jiang 725e41e
[Bugfix] Add global file lock to prevent EADDRINUSE in concurrent sta…
Lidang-Jiang f83a622
[Bugfix] Deduplicate _RepoUtilsLocalPathFilter to module level
Lidang-Jiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setLevel(CRITICAL)suppresses all ERROR logs from transformers — that's pretty broad. Can you target just the specific message instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point — updated in 9ebc167. Replaced
setLevel(CRITICAL)with alogging.Filterthat only suppresses the known-harmless"Error retrieving file list"message. All other ERROR logs (including retry failures) now pass through normally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now — the
logging.Filterapproach is much better thansetLevel(CRITICAL). Only suppresses the known-harmless messages while keeping real errors visible. Thanks for the quick fix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!