Skip to content

[Bugfix] Fix NameError in OmniDiffusion init for Bagel/NextStep after GLM-Image merge #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lishunyang12 wants to merge 1 commit into from
Closed

[Bugfix] Fix NameError in OmniDiffusion init for Bagel/NextStep after GLM-Image merge #1563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions vllm_omni/entrypoints/omni_diffusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,16 @@ def __init__(self, od_config: OmniDiffusionConfig | None = None, **kwargs):
od_config.tf_model_config = TransformerConfig()
od_config.update_multimodal_support()
elif model_type == "glm-image" or "GlmImageForConditionalGeneration" in architectures:
pipeline_class = "GlmImagePipeline"
od_config.model_class_name = "GlmImagePipeline"
od_config.tf_model_config = TransformerConfig()
od_config.update_multimodal_support()
elif architectures and len(architectures) == 1:
pipeline_class = architectures[0]

if pipeline_class is None:
od_config.model_class_name = architectures[0]
od_config.tf_model_config = TransformerConfig()
od_config.update_multimodal_support()
else:
raise ValueError(f"Unknown model type: {model_type}, architectures: {architectures}")

od_config.model_class_name = pipeline_class
od_config.tf_model_config = TransformerConfig()
od_config.update_multimodal_support()

@Semmer2 Semmer2 Feb 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Shunyang, I thinke these three lines of code is common, which should not be deleted and added in former if-else code.

self.engine: DiffusionEngine = DiffusionEngine.make_engine(od_config)

def generate(
Expand Down