Skip to content

[Enhancement] Patch OmniStage.try_collect() with _proc alive checks #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsliuustc0106 merged 4 commits into from
Mar 12, 2026
Merged

[Enhancement] Patch OmniStage.try_collect() with _proc alive checks #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e7b9e8
Patch try collect, check proc alive
pi314ever Feb 27, 2026
70b28b0
Flip order to avoid race conditions
pi314ever Feb 28, 2026
8e79a78
Add exit code in error
pi314ever Feb 28, 2026
4e0fa0c
Use proper is_alive value
pi314ever Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/entrypoints/test_omni_diffusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ def _setup_multiprocessing_mocks(monkeypatch: pytest.MonkeyPatch, mocker: Mocker
fake_process_instance = mocker.MagicMock()
fake_process_instance.start = mocker.MagicMock()
fake_process_instance.join = mocker.MagicMock()
fake_process_instance.is_alive = mocker.MagicMock(return_value=False)
fake_process_instance.is_alive = mocker.MagicMock(return_value=True)
Copy link
Copy Markdown
Contributor Author

@pi314ever pi314ever Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value needs to be set True to allow _proc.is_alive() check on mocks to pass. There is no reason to set is_alive to False unless testing process failure test case.

fake_process_instance.terminate = mocker.MagicMock()
fake_process_class.return_value = fake_process_instance

Expand Down
10 changes: 8 additions & 2 deletions vllm_omni/entrypoints/omni_stage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,8 +693,14 @@ def try_collect(self) -> dict[str, Any] | None:
assert self._out_q is not None
try:
return self._out_q.get_nowait()
except Exception:
return None
except queue.Empty:
pass
except Exception as e:
logger.error("Unexpected error when collecting OmniStage output queue:", exc_info=e)
self.stop_stage_worker()
raise
if self._proc is not None and not self._proc.is_alive():
raise RuntimeError(f"OmniStage Worker process died unexpectedly with exit code {self._proc.exitcode}")

def process_engine_inputs(
self,
Expand Down