[feature] : add cache-dit for stable-audio-open-1.0#1341
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf50517d5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
fix DCO please |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
…g warmup" This reverts commit e4c5a1f. Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
cf50517 to
4569fd7
Compare
|
@hsliuustc0106 Sorry! I've updated it ! |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
…p/cache-dit Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
…tion Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
lishunyang12
left a comment
There was a problem hiding this comment.
Good addition -- the backend code looks correct after the Pattern_3 + cache_config fixes, but the docs table has a column count mismatch that will render broken.
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
|
@vllm-omni-reviewer |
|
@akshatvishu Please resolve reviews and conficts. Thanks! |
|
@akshatvishu any updates? |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
|
@linyueqian Ready to go from my side ! Happy to conduct any more test if needed! |
|
mkdocs ci were failing due to :
Since main already has the fix, pulled the latest changes. |
|
resolve conflicts please |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
|
@hsliuustc0106 done! |
|
thanks for all the reviews @linyueqian ! |
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Part of #1217
Purpose
Add cache-dit support for stable audio open 1.0
Test Plan
full comprehensive testing can be found in this kaggle_notebook
Test Result
Device:
cudaGPU:
NVIDIA Tesla T4Prompt :
The sound of a hammer hitting a wooden surfacenum_inference_steps=
100guidance_scale=
7.0,max_audio_length =
10 secondsBaseline:
Config1:
Config2:
Config3:
Files are in
.mp3format as github doesn't support.wavin comments.Note :
Stable Audio Open 1.0 exhibits a high natural step-to-step drift (median residual ≈0.34) as seen in
cache-dit.summary()when running the same config as vllm-omni in hf diffuser+cache-dit setup. To achieve significant speedups on T4 hardware, it is necessary to use aresidual_diff_thresholdnear or above this drift value as using conservativeresidual_diff_thresholdlike0.12resulted in1.00xspeedup (or even slowdowns) because the cache missed on nearly every step, leaving only the management overhead without any compute savings.The vllm-omni orchestrator performs a 1-step dummy warmup run during server initialization, If a user provides an SCM (Step Computation Masking) policy, the engine crashes with the following error:
Thus, I am wondering if we should a guard condition like below or it's an acceptable behavior.
_repeated_blocks = ["StableAudioDiTBlock"]toStableAudioDiTModelto enable regional compilation and backend patching.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)