Buildkite hardware ci xpu test#1340
Conversation
596b8f4 to
22f7ab4
Compare
cab95fa to
b071308
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0713083a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lishunyang12
left a comment
There was a problem hiding this comment.
Straightforward CI script addition -- a few nits below, mostly around hardening and a stale comment.
|
@vllm-omni-reviewer |
lishunyang12
left a comment
There was a problem hiding this comment.
Looks good now, thanks for the quick turnaround on the fixes.
1e78648 to
18a24ca
Compare
|
Recent changes are for more feature-based testing (testing for features that have passed for XPU on B60 nodes) as opposed to sweeping all available tests. For future PRs that enable certain features, tests should be added as they are enabled on XPU. |
xuechendi
left a comment
There was a problem hiding this comment.
Thanks, @pi314ever , looks good to me.
@hsliuustc0106 , @gcanlin , may you take a look, thanks so much
We're upgrading to v0.17.0. Please wait #1639 merged, then rebase this PR based on v0.17.0. Feel free to ping me again when the rebasing is ready :) |
febc254 to
dabdb8f
Compare
|
@gcanlin Rebased! |
gcanlin
left a comment
There was a problem hiding this comment.
LGTM. Just one non-blocking thought: I notice that we're introducing many config dispatch for platform in tests. Not sure whether we have the way to clean up them.
Thanks for the review. Let's put this as an AR. Will follow up with a different PR. I am think we can at least reuse existing one in platforms/xpu/stage_configs? So all these config can get tested as well? Also, will also need to provide multiple folders under platforms/${HW}/stage_configs/ for different products which are with different device_memory_size, so config will also be different |
507fade to
9a25375
Compare
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
3603e37 to
79bb1ad
Compare
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
|
@congw729 @gcanlin @hsliuustc0106 |
|
currently, do we have access to the hardware to run the pipeline? |
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com> Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: Daniel Huang <daniel1.huang@intel.com>


PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Adds hardware CI for Intel XPU via buildkite. Relies on #1162 for XPU docker.
Test Plan
Test Result
All tests pass on 8xB60.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)