Skip to content

[Hardware] Support platform-aware dependency routing#1040

Closed
gcanlin wants to merge 7 commits into
vllm-project:mainfrom
gcanlin:deps
Closed

[Hardware] Support platform-aware dependency routing#1040
gcanlin wants to merge 7 commits into
vllm-project:mainfrom
gcanlin:deps

Conversation

@gcanlin
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin commented Jan 29, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Close #997.

Test Plan

TODO

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: gcanlin <canlinguosdu@gmail.com>

Co-authored-by: PopSoda2002 <zhouhp.me@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 056101ebfb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread setup.py
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@david6666666 david6666666 added this to the v0.14.0 milestone Jan 29, 2026
@david6666666 david6666666 self-requested a review January 29, 2026 03:00
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@hsliuustc0106 hsliuustc0106 added ROCm PR related to AMD hardware NPU PR related to Ascend NPU labels Jan 29, 2026
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@gcanlin
Copy link
Copy Markdown
Collaborator Author

gcanlin commented Jan 29, 2026

  • pip install -v -e . --no-build-isolation can route correctly.
  • pip install -v -e . only installs common.txt.

@tjtanaa Do you have any more well-designed solution? 🤔

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@tjtanaa
Copy link
Copy Markdown
Member

tjtanaa commented Jan 29, 2026

  • pip install -v -e . --no-build-isolation can route correctly.
  • pip install -v -e . only installs common.txt.

@tjtanaa Do you have any more well-designed solution? 🤔

I have mentioned the necessity for non-CUDA non-CPU platform to use --no-build-isolation in my PR #1046 .

Is it ok that we use my PR instead? I have included everyone on coauthor list.

@gcanlin
Copy link
Copy Markdown
Collaborator Author

gcanlin commented Jan 29, 2026

Close as we co-work in #1046.

@gcanlin gcanlin closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPU PR related to Ascend NPU ROCm PR related to AMD hardware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Platform‑Aware Dependency Routing for vLLM‑Omni

4 participants