[kernel] remove eager kernel due to the new primitive#372
Merged
WindChimeRan merged 2 commits intoMay 14, 2026
Merged
Conversation
Signed-off-by: ran <hzz5361@psu.edu>
LxYuan0420
reviewed
May 14, 2026
LxYuan0420
approved these changes
May 14, 2026
Signed-off-by: ran <hzz5361@psu.edu>
WindChimeRan
added a commit
to WindChimeRan/vllm-metal
that referenced
this pull request
May 14, 2026
Resolve modify/delete conflict on test_metal_unified_attention.py: upstream removed the eager kernel test (PR vllm-project#372), we had added prefill test cases. Accept deletion, migrate prefill-only test parametrizations to test_primitive_and_donation.py::test_primitive_vs_reference_varlen. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ricky-chaoju
pushed a commit
that referenced
this pull request
May 15, 2026
## Summary After #372 removed the eager `paged_attention_*` bindings, `PagedAttentionPrimitive::eval_gpu` is the only caller of `dispatch_paged_attention_v2_online` (and indirectly `dispatch_paged_attention_tiled`), and it always passes `from_primitive=true`. The `from_primitive` parameter, the `!from_primitive` `add_temporary` branches in both dispatchers, and the `add_paged_attn_temporaries` helper that those branches called are all unreachable. `vllm_metal/metal/paged_ops.cpp` — 37 lines deleted: - `from_primitive` parameter removed from `dispatch_paged_attention_tiled` and `dispatch_paged_attention_v2_online` - the `if (!from_primitive)` `add_temporary_compat` branches removed in both (including the TurboQuant scale/zero/centroid temporaries) - `add_paged_attn_temporaries` deleted (only those branches called it) - call sites in `dispatch_paged_attention_v2_online → dispatch_paged_attention_tiled` and `PagedAttentionPrimitive::eval_gpu → dispatch_paged_attention_v2_online` updated to drop the argument ## What stays `dispatch_reshape_and_cache` keeps its `from_primitive` parameter — it still has a live eager caller via `reshape_and_cache_impl`, which `vllm_metal/paged_attention_backend/mha.py:47` calls as part of the Metal-shader warm-up. Signed-off-by: Bvicii <yizhanhuang2002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup eager kernel, due to the working primitive (#225)
now eager kernel is dead code