[CI] Remove vllm from [all] extra to fix release CI #176
Merged
LxYuan0420 merged 1 commit intovllm-project:mainfrom Mar 18, 2026
Merged
[CI] Remove vllm from [all] extra to fix release CI #176LxYuan0420 merged 1 commit intovllm-project:mainfrom
LxYuan0420 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Chao-Ju Chen <ricky.chen@infinirc.com>
LxYuan0420
approved these changes
Mar 18, 2026
LxYuan0420
pushed a commit
that referenced
this pull request
Mar 18, 2026
Follow-up to #176. `uv build` validates every extra individually, not just `[all]`. The `[vllm]` extra (`vllm>=0.17.1`) conflicts with `transformers>=5.0.0` in main deps because vllm pins `transformers<5`. Remove the `[vllm]` extra entirely — vllm must be installed via `install.sh`, which handles the transformers override separately. Tested locally: `uv build` succeeds after this change. Signed-off-by: Chao-Ju Chen <ricky.chen@infinirc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv buildvalidates all extras during build isolation. The[all]extra includesvllm>=0.17.1, which pinstransformers<5, conflicting withtransformers>=5.0.0added in #169.Remove
vllmfrom[all]— vllm must be installed separately viainstall.sh(which overrides the transformers pin after installing vllm).https://github.com/vllm-project/vllm-metal/actions/runs/23237769107/job/67548510927