Skip to content

remove stale xfail for batched decode paged-parity test #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renqHIT wants to merge 1 commit into from
Closed

remove stale xfail for batched decode paged-parity test #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/test_metal_kernel_paged.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,6 @@ def test_greedy_output_matches(self, qwen3_model):
)

@pytest.mark.slow
@pytest.mark.xfail(
reason="B=2 batched GEMM produces different floats than B=1, "
"causing token divergence after ~5 decode steps (not a kernel bug). "
"See https://github.com/vllm-project/vllm-metal/issues/119"
)
def test_batched_decode_matches(self, qwen3_model):
"""Batched Metal kernel paged decode must match per-request sequential."""
model, tokenizer = qwen3_model
Expand Down