Skip to content

[FIX_FOR_VLLM_LATEST] Fix the MultiModalKwargsItem to align with vllm changes#903

Closed
pawel-olejniczak wants to merge 27 commits intovllm-project:mainfrom
pawel-olejniczak:dev/polejnix/33331
Closed

[FIX_FOR_VLLM_LATEST] Fix the MultiModalKwargsItem to align with vllm changes#903
pawel-olejniczak wants to merge 27 commits intovllm-project:mainfrom
pawel-olejniczak:dev/polejnix/33331

Conversation

@pawel-olejniczak
Copy link
Copy Markdown
Contributor

@pawel-olejniczak pawel-olejniczak commented Jan 30, 2026 •
edited
Loading

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak pawel-olejniczak marked this pull request as ready for review January 30, 2026 17:41
@github-actions github-actions Bot mentioned this pull request Jan 30, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

✅ CI Passed

All checks passed successfully against the following vllm commit:
3f96fcf64631a100904bb189859f9aa80e8a75d5

@pawel-olejniczak pawel-olejniczak force-pushed the dev/polejnix/33331 branch 3 times, most recently from b04a971 to a206336 Compare February 3, 2026 14:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

Copilot AI review requested due to automatic review settings February 10, 2026 08:47
Copilot AI reviewed Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 10, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

@pawel-olejniczak pawel-olejniczak force-pushed the dev/polejnix/33331 branch 3 times, most recently from 9ef6e39 to 5261273 Compare February 12, 2026 08:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 12, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

@pawel-olejniczak
Fix eos_token_id issue
81176f6 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@pawel-olejniczak
Fix model_type issue
44697ca 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@pawel-olejniczak pawel-olejniczak marked this pull request as draft February 19, 2026 09:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

iboiko-habana pushed a commit that referenced this pull request Feb 19, 2026
@pawel-olejniczak
[FIX_FOR_VLLM_CUSTOM=d2f4a71cd54418369f617a174e6c839a71a47ed8] Hourly…
c79d6fb 
… fixes – batch no. 1 (#988)

This PR contains part of fixes from
#903

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@pawel-olejniczak
Fix kv_offload request/sampling API compatibility
81c20a1 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
SKRohit pushed a commit to SKRohit/vllm-gaudi that referenced this pull request Feb 20, 2026
@pawel-olejniczak @SKRohit
[FIX_FOR_VLLM_CUSTOM=d2f4a71cd54418369f617a174e6c839a71a47ed8] Hourly…
10c2c74 
… fixes – batch no. 1 (vllm-project#988)

This PR contains part of fixes from
vllm-project#903

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
Signed-off-by: Rohit kumar Singh <rksingh@habana.ai>
@pawel-olejniczak pawel-olejniczak mentioned this pull request Feb 20, 2026
Merged
gyou2021 pushed a commit to gyou2021/vllm-gaudi that referenced this pull request Feb 21, 2026
@pawel-olejniczak @gyou2021
[FIX_FOR_VLLM_CUSTOM=d2f4a71cd54418369f617a174e6c839a71a47ed8] Hourly…
54083d0 
… fixes – batch no. 1 (vllm-project#988)

This PR contains part of fixes from
vllm-project#903

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 23, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak
Add oot_mla plugabble layer
d8d3427 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@pawel-olejniczak
Temporarly disable gsm8k_deepseek_unified_mla_test
d35ec4f 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@pawel-olejniczak
Add WA for topk_softmax issue
7733e4e 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@pawel-olejniczak
Remove dead code
b626a1d 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 23, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak
Fix use_dp_chunking issue
8d6312c 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 23, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak
Add WA for is_internal_router issue
7e3b15b 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
iboiko-habana added a commit that referenced this pull request Feb 23, 2026
@pawel-olejniczak @iboiko-habana
[FIX_FOR_VLLM_CUSTOM=dc6de33c3d5e9026cef7b27791dfe0f98e64bbde] Hourly…
15d2664 
… fixes – batch no. 2 (#998)

This PR contains part of fixes from
#903
Fixed issues:
AttributeError: '_OpNamespace' '_moe_C' object has no attribute
'topk_softmax'
AttributeError: 'HPUVocabParallelEmbeddingWithLoRA' object has no
attribute 'quant_method'

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
Co-authored-by: Iryna Boiko <iryna.boiko@intel.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak
Fix use_pplx_kernels issue
d0f226d 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak
Fix dp_size issue
21fe74d 
Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@pawel-olejniczak pawel-olejniczak mentioned this pull request Feb 26, 2026
Merged
iboiko-habana added a commit that referenced this pull request Mar 6, 2026
@pawel-olejniczak @iboiko-habana
[FIX_FOR_VLLM_CUSTOM=ff1f83b056aedcf3e2d978d267011b2b79c08aca] Hourly…
16b15c7 
… fixes – batch no. 3 (#1053)

This PR contains part of fixes from
#903
Fixed issues:
AttributeError: 'FusedMoE' object has no attribute 'forward_impl'
AttributeError: 'PatchedMixtralMoE' object has no attribute
'is_internal_router'
RuntimeError: Overloaded torch operator invoked from Python failed to
match any schema
TypeError: HpuPlatform.get_attn_backend_cls() got an unexpected keyword
argument 'num_heads'
TypeError: Request.__init__() got an unexpected keyword argument
'eos_token_id'
KeyError: 'model_type'
AttributeError: 'FusedMoE' object has no attribute 'dp_size'. Did you
mean: 'ep_size'?
AttributeError: 'SharedFusedMoE' object has no attribute
'use_dp_chunking'
AttributeError: 'SharedFusedMoE' object has no attribute
'use_pplx_kernels'
AttributeError: 'SharedFusedMoE' object has no attribute 'dp_size'. Did
you mean: 'ep_size'?
TypeError: HpuDeepseekOCRDummyInputsBuilder.get_dummy_mm_data() got an
unexpected keyword argument 'mm_processor_kwargs'

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
Co-authored-by: Iryna Boiko <iryna.boiko@intel.com>
SKRohit pushed a commit to SKRohit/vllm-gaudi that referenced this pull request Mar 12, 2026
@pawel-olejniczak @iboiko-habana @SKRohit
[FIX_FOR_VLLM_CUSTOM=ff1f83b056aedcf3e2d978d267011b2b79c08aca] Hourly…
6100202 
… fixes – batch no. 3 (vllm-project#1053)

This PR contains part of fixes from
vllm-project#903
Fixed issues:
AttributeError: 'FusedMoE' object has no attribute 'forward_impl'
AttributeError: 'PatchedMixtralMoE' object has no attribute
'is_internal_router'
RuntimeError: Overloaded torch operator invoked from Python failed to
match any schema
TypeError: HpuPlatform.get_attn_backend_cls() got an unexpected keyword
argument 'num_heads'
TypeError: Request.__init__() got an unexpected keyword argument
'eos_token_id'
KeyError: 'model_type'
AttributeError: 'FusedMoE' object has no attribute 'dp_size'. Did you
mean: 'ep_size'?
AttributeError: 'SharedFusedMoE' object has no attribute
'use_dp_chunking'
AttributeError: 'SharedFusedMoE' object has no attribute
'use_pplx_kernels'
AttributeError: 'SharedFusedMoE' object has no attribute 'dp_size'. Did
you mean: 'ep_size'?
TypeError: HpuDeepseekOCRDummyInputsBuilder.get_dummy_mm_data() got an
unexpected keyword argument 'mm_processor_kwargs'

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
Co-authored-by: Iryna Boiko <iryna.boiko@intel.com>
shepark pushed a commit to libinta/vllm-gaudi that referenced this pull request Mar 19, 2026
@pawel-olejniczak @iboiko-habana
[FIX_FOR_VLLM_CUSTOM=ff1f83b056aedcf3e2d978d267011b2b79c08aca] Hourly…
df319b5 
… fixes – batch no. 3 (vllm-project#1053)

This PR contains part of fixes from
vllm-project#903
Fixed issues:
AttributeError: 'FusedMoE' object has no attribute 'forward_impl'
AttributeError: 'PatchedMixtralMoE' object has no attribute
'is_internal_router'
RuntimeError: Overloaded torch operator invoked from Python failed to
match any schema
TypeError: HpuPlatform.get_attn_backend_cls() got an unexpected keyword
argument 'num_heads'
TypeError: Request.__init__() got an unexpected keyword argument
'eos_token_id'
KeyError: 'model_type'
AttributeError: 'FusedMoE' object has no attribute 'dp_size'. Did you
mean: 'ep_size'?
AttributeError: 'SharedFusedMoE' object has no attribute
'use_dp_chunking'
AttributeError: 'SharedFusedMoE' object has no attribute
'use_pplx_kernels'
AttributeError: 'SharedFusedMoE' object has no attribute 'dp_size'. Did
you mean: 'ep_size'?
TypeError: HpuDeepseekOCRDummyInputsBuilder.get_dummy_mm_data() got an
unexpected keyword argument 'mm_processor_kwargs'

---------

Signed-off-by: Paweł Olejniczak <polejniczakx@habana.ai>
Co-authored-by: Iryna Boiko <iryna.boiko@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@michalkuligowski michalkuligowski michalkuligowski approved these changes

@iboiko-habana iboiko-habana iboiko-habana approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel

@xuechendi xuechendi Awaiting requested review from xuechendi xuechendi is a code owner

@adobrzyn adobrzyn Awaiting requested review from adobrzyn adobrzyn is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

@kamil-kaczor kamil-kaczor Awaiting requested review from kamil-kaczor kamil-kaczor is a code owner

@ksmusz ksmusz Awaiting requested review from ksmusz ksmusz is a code owner

@jbyczkow jbyczkow Awaiting requested review from jbyczkow jbyczkow will be requested when the pull request is marked ready for review jbyczkow is a code owner

@PatrykWo PatrykWo Awaiting requested review from PatrykWo PatrykWo will be requested when the pull request is marked ready for review PatrykWo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pawel-olejniczak @michalkuligowski @iboiko-habana