Revert "skip HPU graphs for long prefills" (#850)#888
Merged
mgawarkiewicz-intel merged 1 commit intoJan 28, 2026
Conversation
Reverts #780 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Co-authored-by: Chendi.Xue <chendi.xue@intel.com>
adobrzyn
requested review from
mgawarkiewicz-intel,
piotrbocian and
wpyszka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous change that skipped HPU graphs for long prefills (#780). The revert simplifies the graph capture decision logic and modifies test configurations.
Changes:
- Reverted the logic for determining when to bypass HPU graphs, replacing a complex condition involving sequence length and batched tokens with a simpler check based on
max_cudagraph_capture_size - Updated test configurations by reducing max-model-len in performance tests and adding it to GSM8K tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vllm_gaudi/v1/worker/hpu_model_runner.py | Simplified graph capture logic and removed max_graph_capture_tokens variable |
| tests/full_tests/ci_perf_tests.sh | Reduced max-model-len from 32768 to 16384 |
| tests/full_tests/ci_gsm8k_tests.sh | Added max-model-len parameter (131072) to Qwen3 MOE test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ CI PassedAll checks passed successfully against the following vllm commit: |
mgawarkiewicz-intel
approved these changes
Jan 28, 2026
slokesha
pushed a commit
to libinta/vllm-gaudi
that referenced
this pull request
Jan 29, 2026
…roject#888) Reverts vllm-project#780 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Co-authored-by: Chendi.Xue <chendi.xue@intel.com> Signed-off-by: slokesha <slokeshappa@habana.ai>
czhu15
added a commit
that referenced
this pull request
Feb 10, 2026
yangulei
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #780