[FIX_FOR_VLLM_LATEST] Fix for hourly#697
Merged
iboiko-habana merged 2 commits intomainfrom Dec 8, 2025
Merged
Conversation
Signed-off-by: Dobrzyniewicz, Agata <agata.dobrzyniewicz@intel.com>
adobrzyn
requested review from
afierka-intel,
iboiko-habana,
kamil-kaczor,
ksmusz,
kzawora-intel,
mgawarkiewicz-intel,
michalkuligowski and
xuechendi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a missing remote_request_id field to a request configuration dictionary to fix compatibility with the latest version of vLLM. The change addresses breaking changes introduced in vllm-project/vllm#29665.
Key Changes:
- Added
remote_request_idparameter to the request configuration insend_request_to_servicefunction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dobrzyniewicz, Agata <agata.dobrzyniewicz@intel.com>
✅ CI PassedAll checks passed successfully against the following vllm commit: |
iboiko-habana
changed the title
iboiko-habana
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Culprit: vllm-project/vllm#29665 and vllm-project/vllm#27938