Add support for chunked attention (#597)#612
Merged
wpyszka merged 1 commit intoNov 21, 2025
Merged
Conversation
Cherry-pick of vllm-project@6e1be4e --------- Signed-off-by: Jan Kaniecki <jkaniecki@habana.ai> Signed-off-by: Jan Kaniecki <jan.kaniecki@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jkaniecki
requested review from
mgawarkiewicz-intel,
piotrbocian and
wpyszka
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for chunked attention mechanism to the vLLM-Gaudi implementation. The key changes introduce infrastructure to handle attention computations in chunks, which can improve memory efficiency and performance for long sequences.
Key Changes:
- Added chunked attention bias computation for both prefill and decode phases
- Extended attention metadata structures to include chunked attention fields
- Implemented logic to detect and configure models with chunked attention support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| vllm_gaudi/v1/worker/hpu_model_runner.py | Implements chunked attention support with bias computation, block mapping, metadata updates, and model initialization logic |
| vllm_gaudi/v1/attention/backends/hpu_attn.py | Extends decode metadata creation to accept chunked attention parameters |
| vllm_gaudi/attention/backends/hpu_attn.py | Adds chunked attention fields to metadata class and implements selection logic in forward pass |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ CI PassedAll checks passed successfully against the following vllm commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of
6e1be4e