[FIX for upstream changes ]hpu_model_runner and add UT#3
Merged
Conversation
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
adobrzyn
added a commit
that referenced
this pull request
Sep 8, 2025
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
skavulya
pushed a commit
to skavulya/vllm-gaudi
that referenced
this pull request
Nov 25, 2025
8 tasks
afierka-intel
pushed a commit
that referenced
this pull request
Feb 19, 2026
- Use pip check to verify python dependencies during build - Use no-cache to reduce the docker image size - Allow using `latest` in sysnapse revision - [x] TODO remove CRB - [x] Test the changes More changes to check and implement: - [x] 1) Around line 46, is this RUN dnf install -y python3-dnf-plugin-versionlock. It needs to start off with dnf -y update to pull in all updates before centos/epel repos get installed. - [x] 2) At line 62, it tries to install libjpeg-devel. The replacement on RHEL 9 is libjpeg-turbo-devel. It’s a drop in replacement that runs even faster. And it is in the main UBI repo and not epel. - [x] 3) Down around line 130, is a dnf -y update. Delete this block as this will pull in all kinds of Centos contamination. - [x] 4) Not strictly required, but at line 139, make it FROM gaudi-pytorch as vllm-openai to match other vllm images. - [x] 5) At line 153, there is another dnf -y update, remove it for the same reason as #3 - [x] retest --------- Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Patryk Wolsza <patryk.wolsza@intel.com>
SKRohit
pushed a commit
to SKRohit/vllm-gaudi
that referenced
this pull request
Feb 20, 2026
- Use pip check to verify python dependencies during build - Use no-cache to reduce the docker image size - Allow using `latest` in sysnapse revision - [x] TODO remove CRB - [x] Test the changes More changes to check and implement: - [x] 1) Around line 46, is this RUN dnf install -y python3-dnf-plugin-versionlock. It needs to start off with dnf -y update to pull in all updates before centos/epel repos get installed. - [x] 2) At line 62, it tries to install libjpeg-devel. The replacement on RHEL 9 is libjpeg-turbo-devel. It’s a drop in replacement that runs even faster. And it is in the main UBI repo and not epel. - [x] 3) Down around line 130, is a dnf -y update. Delete this block as this will pull in all kinds of Centos contamination. - [x] 4) Not strictly required, but at line 139, make it FROM gaudi-pytorch as vllm-openai to match other vllm images. - [x] 5) At line 153, there is another dnf -y update, remove it for the same reason as vllm-project#3 - [x] retest --------- Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Patryk Wolsza <patryk.wolsza@intel.com> Signed-off-by: Rohit kumar Singh <rksingh@habana.ai>
gyou2021
pushed a commit
to gyou2021/vllm-gaudi
that referenced
this pull request
Feb 21, 2026
- Use pip check to verify python dependencies during build - Use no-cache to reduce the docker image size - Allow using `latest` in sysnapse revision - [x] TODO remove CRB - [x] Test the changes More changes to check and implement: - [x] 1) Around line 46, is this RUN dnf install -y python3-dnf-plugin-versionlock. It needs to start off with dnf -y update to pull in all updates before centos/epel repos get installed. - [x] 2) At line 62, it tries to install libjpeg-devel. The replacement on RHEL 9 is libjpeg-turbo-devel. It’s a drop in replacement that runs even faster. And it is in the main UBI repo and not epel. - [x] 3) Down around line 130, is a dnf -y update. Delete this block as this will pull in all kinds of Centos contamination. - [x] 4) Not strictly required, but at line 139, make it FROM gaudi-pytorch as vllm-openai to match other vllm images. - [x] 5) At line 153, there is another dnf -y update, remove it for the same reason as vllm-project#3 - [x] retest --------- Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Patryk Wolsza <patryk.wolsza@intel.com>
PatrykWo
added a commit
that referenced
this pull request
Feb 26, 2026
- Use pip check to verify python dependencies during build - Use no-cache to reduce the docker image size - Allow using `latest` in sysnapse revision - [x] TODO remove CRB - [x] Test the changes More changes to check and implement: - [x] 1) Around line 46, is this RUN dnf install -y python3-dnf-plugin-versionlock. It needs to start off with dnf -y update to pull in all updates before centos/epel repos get installed. - [x] 2) At line 62, it tries to install libjpeg-devel. The replacement on RHEL 9 is libjpeg-turbo-devel. It’s a drop in replacement that runs even faster. And it is in the main UBI repo and not epel. - [x] 3) Down around line 130, is a dnf -y update. Delete this block as this will pull in all kinds of Centos contamination. - [x] 4) Not strictly required, but at line 139, make it FROM gaudi-pytorch as vllm-openai to match other vllm images. - [x] 5) At line 153, there is another dnf -y update, remove it for the same reason as #3 - [x] retest --------- Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Patryk Wolsza <patryk.wolsza@intel.com> (cherry picked from commit a3855ac)
PatrykWo
added a commit
that referenced
this pull request
Feb 26, 2026
- Use pip check to verify python dependencies during build - Use no-cache to reduce the docker image size - Allow using `latest` in sysnapse revision - [x] TODO remove CRB - [x] Test the changes More changes to check and implement: - [x] 1) Around line 46, is this RUN dnf install -y python3-dnf-plugin-versionlock. It needs to start off with dnf -y update to pull in all updates before centos/epel repos get installed. - [x] 2) At line 62, it tries to install libjpeg-devel. The replacement on RHEL 9 is libjpeg-turbo-devel. It’s a drop in replacement that runs even faster. And it is in the main UBI repo and not epel. - [x] 3) Down around line 130, is a dnf -y update. Delete this block as this will pull in all kinds of Centos contamination. - [x] 4) Not strictly required, but at line 139, make it FROM gaudi-pytorch as vllm-openai to match other vllm images. - [x] 5) At line 153, there is another dnf -y update, remove it for the same reason as #3 - [x] retest --------- Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Patryk Wolsza <patryk.wolsza@intel.com> (cherry picked from commit a3855ac) Signed-off-by: PatrykWo <patryk.wolsza@intel.com>
afierka-intel
added a commit
to afierka-intel/vllm-gaudi
that referenced
this pull request
Mar 12, 2026
- Use local 'effective_total_tokens' instead of reassigning 'total_num_scheduled_tokens' to avoid side effects (finding vllm-project#2) - Guard 'req_start_idx' accumulation with 'if padded_seq_len is None' to avoid dead code in the padded path (finding vllm-project#3) - Add unit tests for _gather_mm_embeddings covering both 2D padded and 1D non-padded paths (finding vllm-project#1)
adobrzyn
added a commit
that referenced
this pull request
Mar 31, 2026
- Use pip check to verify python dependencies during build - Use no-cache to reduce the docker image size - Allow using `latest` in sysnapse revision - [x] TODO remove CRB - [x] Test the changes More changes to check and implement: - [x] 1) Around line 46, is this RUN dnf install -y python3-dnf-plugin-versionlock. It needs to start off with dnf -y update to pull in all updates before centos/epel repos get installed. - [x] 2) At line 62, it tries to install libjpeg-devel. The replacement on RHEL 9 is libjpeg-turbo-devel. It’s a drop in replacement that runs even faster. And it is in the main UBI repo and not epel. - [x] 3) Down around line 130, is a dnf -y update. Delete this block as this will pull in all kinds of Centos contamination. - [x] 4) Not strictly required, but at line 139, make it FROM gaudi-pytorch as vllm-openai to match other vllm images. - [x] 5) At line 153, there is another dnf -y update, remove it for the same reason as #3 - [x] retest --------- Signed-off-by: Adam Ghandoura <adam.ghandoura@intel.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Patryk Wolsza <patryk.wolsza@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.