Skip to content

ci: enforce egress allow-list on jobs that consume HF_TOKEN #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adobrzyn wants to merge 1 commit into from
Closed

ci: enforce egress allow-list on jobs that consume HF_TOKEN #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions .github/workflows/create-release-branch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,33 @@ jobs:
# --- UPDATED: Run on the specific node ---
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
Comment on lines +168 to +174
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run pytest in tests/unit_tests
run: |
EXITCODE=1
Expand Down Expand Up @@ -222,6 +249,33 @@ jobs:
test_function: ${{ fromJson(needs.discover_tests.outputs.matrix) }}

steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run test suite - ${{ matrix.test_function }}
run: |
EXITCODE=1
Expand Down Expand Up @@ -249,6 +303,33 @@ jobs:
# --- UPDATED: Run on the specific node ---
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run Data Parallel test
run: |
EXITCODE=1
Expand Down Expand Up @@ -276,6 +357,33 @@ jobs:
# --- UPDATED: Run on the specific node ---
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run PD disaggregate test
run: |
EXITCODE=1
Expand Down Expand Up @@ -306,6 +414,33 @@ jobs:
# --- UPDATED: Run on the specific node ---
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run Sharegpt performance tests with warmup
run: |
EXITCODE=1
Expand Down
108 changes: 108 additions & 0 deletions .github/workflows/hourly-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,33 @@ jobs:
# <-- UPDATED: Runs on the specific runner
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
Comment on lines +105 to +111
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run pytest in tests/unit_tests
run: |
EXITCODE=1
Expand Down Expand Up @@ -164,6 +191,33 @@ jobs:
test_function: ${{ fromJson(needs.discover_tests.outputs.matrix) }}

steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run test suite - ${{ matrix.test_function }}
run: |
EXITCODE=1
Expand Down Expand Up @@ -193,6 +247,33 @@ jobs:
# <-- UPDATED: Runs on the specific runner
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run Data Parallel test
run: |
EXITCODE=1
Expand Down Expand Up @@ -221,6 +302,33 @@ jobs:
# <-- UPDATED: Runs on the specific runner
runs-on: ${{ needs.discover_runner.outputs.runner_name }}
steps:
- name: Harden runner (egress block)
uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5 # v2.19.3
with:
egress-policy: block
disable-sudo: false
allowed-endpoints: >
api.github.com:443
github.com:443
codeload.github.com:443
objects.githubusercontent.com:443
raw.githubusercontent.com:443
release-assets.githubusercontent.com:443
*.actions.githubusercontent.com:443
results-receiver.actions.githubusercontent.com:443
ghcr.io:443
pkg-containers.githubusercontent.com:443
*.blob.core.windows.net:443
vault.habana.ai:443
pypi.org:443
files.pythonhosted.org:443
download.pytorch.org:443
huggingface.co:443
cdn-lfs.huggingface.co:443
cdn-lfs.hf.co:443
cdn-lfs-us-1.hf.co:443
cas-bridge.xethub.hf.co:443
xet-lfs-us-1.hf.co:443
- name: Run PD disaggregate test
run: |
EXITCODE=1
Expand Down
Loading