Harden Qwen3.5 CI test to detect regressions#1443
Merged
iboiko-habana merged 5 commits intoMay 18, 2026
Merged
Conversation
Signed-off-by: Seunghyuk Park <separk@habana.ai>
shepark
requested review from
PatrykWo,
adobrzyn,
afierka-intel,
iboiko-habana,
jbyczkow,
kamil-kaczor,
ksmusz,
mgawarkiewicz-intel,
michalkuligowski and
xuechendi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Qwen3.5-35B-A3B GSM8K CI signal to better detect accuracy regressions that only appear at larger prompt batching, aligning coverage with the regression fixed in #1433.
Changes:
- Increase CI coverage by running the Qwen3.5 GSM8K test with
VLLM_PROMPT_BS_BUCKET_MAX=32. - Tighten the GSM8K exact-match pass threshold for the Qwen3.5-35B-A3B model card (0.75 → 0.9).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/full_tests/model_cards/qwen3.5-35b-a3b.yaml |
Raises the required GSM8K exact-match threshold to better catch future accuracy regressions. |
tests/full_tests/ci_e2e_discoverable_tests.sh |
Sets VLLM_PROMPT_BS_BUCKET_MAX=32 for the Qwen3.5 GSM8K CI run to exercise larger prompt batch bucketing behavior. |
adobrzyn
approved these changes
May 13, 2026
✅ CI PassedAll checks passed successfully against the following vllm commit: |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
✅ CI PassedAll checks passed successfully against the following vllm commit: |
iboiko-habana
pushed a commit
that referenced
this pull request
May 18, 2026
#1433 fixed a Qwen3.5 accuracy regression that was only detected when the prompt bucket batch size is large. Adding VLLM_PROMPT_BS_BUCKET_MAX=32 to the CI test covers that case. Also tighten the passing threshold to better catch future regressions. Signed-off-by: Seunghyuk Park <separk@habana.ai> Co-authored-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Libin Tang <libin.tang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1433 fixed a Qwen3.5 accuracy regression that was only detected
when the prompt bucket batch size is large. Adding VLLM_PROMPT_BS_BUCKET_MAX=32 to the CI test covers that case.
Also tighten the passing threshold to better catch future regressions.