Skip to content

fix: review findings #1, #2 from PR #1126#1148

Closed
adobrzyn wants to merge 1 commit into
gaudisw-245712-mm-prefill-batchingfrom
fix/pr-1126-review-findings
Closed

fix: review findings #1, #2 from PR #1126#1148
adobrzyn wants to merge 1 commit into
gaudisw-245712-mm-prefill-batchingfrom
fix/pr-1126-review-findings

Conversation

@adobrzyn
Copy link
Copy Markdown
Collaborator

Fixes from code review of #1126:

  • Add pre-commit GHA #1: Add unit tests for _gather_mm_embeddings covering single-request, two-request contiguous, and 2D padded batching paths
  • Refactor vllm_hpu -> vllm_gaudi #2: Use separate local variable (effective_total_tokens) instead of overriding the total_num_scheduled_tokens parameter in _get_model_mm_inputs

[- Reviewed by Awesome ChlOpus]

- #1: Add unit tests for _gather_mm_embeddings covering 1D contiguous
  and 2D padded batching paths
- #2: Use separate local variable (effective_total_tokens) instead of
  overriding the total_num_scheduled_tokens parameter in _get_model_mm_inputs

[- Reviewed by Awesome ChlOpus]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant