Skip to content

[Scheduler][MTP] Add support for speculative decoding in AsecendScheduler.#943

Merged
ganyi1996ppo merged 8 commits intovllm-project:mainfrom
whx-sjtu:adapt_ascend_scheduler_090
Jun 11, 2025
Merged

[Scheduler][MTP] Add support for speculative decoding in AsecendScheduler.#943
ganyi1996ppo merged 8 commits intovllm-project:mainfrom
whx-sjtu:adapt_ascend_scheduler_090

Conversation

@whx-sjtu
Copy link
Copy Markdown
Collaborator

@whx-sjtu whx-sjtu commented May 24, 2025

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support will be merged in follow-up PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch from 7324819 to 08d08fa Compare June 5, 2025 08:22
@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch from 08d08fa to d1f53f8 Compare June 5, 2025 08:27
@whx-sjtu whx-sjtu changed the title [Scheduler][P/D] Add support for disaggregated prefill in AsecendScheduler. [Scheduler][P/D] Add support for speculative decoding in AsecendScheduler. Jun 5, 2025
@whx-sjtu whx-sjtu changed the title [Scheduler][P/D] Add support for speculative decoding in AsecendScheduler. [Scheduler][MTP] Add support for speculative decoding in AsecendScheduler. Jun 5, 2025
@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch 3 times, most recently from e650a1d to a543e1f Compare June 5, 2025 11:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch from a543e1f to 39d6cd1 Compare June 8, 2025 16:11
@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch 2 times, most recently from efd6283 to 4b75f27 Compare June 9, 2025 10:17
@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch 6 times, most recently from aa007f1 to aa52202 Compare June 10, 2025 09:30
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

whx-sjtu added 4 commits June 11, 2025 16:41
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
whx-sjtu added 3 commits June 11, 2025 16:43
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: whx-sjtu <2952154980@qq.com>
@whx-sjtu whx-sjtu force-pushed the adapt_ascend_scheduler_090 branch from feb3765 to 873f2c1 Compare June 11, 2025 08:43
Signed-off-by: whx-sjtu <2952154980@qq.com>
@ganyi1996ppo ganyi1996ppo merged commit 3393d53 into vllm-project:main Jun 11, 2025
22 of 23 checks passed
Comment on lines +188 to +189
# pytest -sv tests/singlecard/core/test_ascend_scheduler.py
# pytest -sv tests/singlecard/core/test_ascend_scheduler_e2e.py
Copy link
Copy Markdown
Member

@Yikun Yikun Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR drop the scheduler test, any plan to re-add? @ganyi1996ppo @whx-sjtu

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because AscendScheduler is designed for v1, so I close ut of it in ci of v0.

Copy link
Copy Markdown
Member

@Yikun Yikun Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you disabled the v1...😂

Yikun pushed a commit that referenced this pull request Jun 12, 2025
Last PR [#943 ](#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…uler. (vllm-project#943)

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support
will be merged in follow-up PR.

---------

Signed-off-by: whx-sjtu <2952154980@qq.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…1180)

Last PR [vllm-project#943 ](vllm-project#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…uler. (vllm-project#943)

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support
will be merged in follow-up PR.

---------

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…1180)

Last PR [vllm-project#943 ](vllm-project#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…uler. (vllm-project#943)

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support
will be merged in follow-up PR.

---------

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…1180)

Last PR [vllm-project#943 ](vllm-project#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
shiyuan680 pushed a commit to raindaywhu/vllm-ascend that referenced this pull request Jul 7, 2025
…uler. (vllm-project#943)

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support
will be merged in follow-up PR.

---------

Signed-off-by: whx-sjtu <2952154980@qq.com>
shiyuan680 pushed a commit to raindaywhu/vllm-ascend that referenced this pull request Jul 7, 2025
…1180)

Last PR [vllm-project#943 ](vllm-project#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
@whx-sjtu whx-sjtu deleted the adapt_ascend_scheduler_090 branch July 9, 2025 07:10
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
…uler. (vllm-project#943)

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support
will be merged in follow-up PR.

---------

Signed-off-by: whx-sjtu <2952154980@qq.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Oct 16, 2025
…1180)

Last PR [vllm-project#943 ](vllm-project#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…uler. (vllm-project#943)

This PR adds support for speculative decoding in AsecendScheduler.
Also inculde part of support for disaggregated prefill, full support
will be merged in follow-up PR.

---------

Signed-off-by: whx-sjtu <2952154980@qq.com>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
…1180)

Last PR [vllm-project#943 ](vllm-project#943)
wrongly open ut of AscendScheduler in V0 ci, this PR fixes this problem
and only run ut of it in V1 ci.

Signed-off-by: whx-sjtu <2952154980@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants