Skip to content

[CI] Upgrade vllm commit to 0512#9054

Closed
Potabk wants to merge 19 commits into
vllm-project:mainfrom
Potabk:main2main_05
Closed

[CI] Upgrade vllm commit to 0512#9054
Potabk wants to merge 19 commits into
vllm-project:mainfrom
Potabk:main2main_05

Conversation

@Potabk
Copy link
Copy Markdown
Collaborator

@Potabk Potabk commented May 11, 2026

What this PR does / why we need it?

  1. fix [Bugfix] Fix SP pass for multimodal models and PP+SP residual handling vllm#33322
    overwrite gpu_modelrunner.sync_and_gather_intermediate_tensors, for the sceniro pp+sp+tp, skip scatter the residual for ascend

  2. [Model Runner V2] support qwen35 / mamba hybrid model vllm#35520
    Adapted to the modifications of ModelRunner v2 for hybrid attn in interface level, .
    Todo: Added support for Mamba in ModelRunner in Ascend. any pull_request is welcome

  3. [Aiter][ROCm] gdn_linear_attn kernel fusion vllm#40711

  4. [Attention][Cleanup] Remove tree attention vllm#42121

  5. [Model] use AutoWeightsLoader for DeepSeekV2 vllm#41706

  6. [Core] Replace routing replay with device cache and async D2H pipeline vllm#39917
    Disable async_schedule when enable_return_routed_experts=True

  7. [MoE Refactor] Move expert map related code into ExpertMapManager class vllm#41046

  8. [MoE Refactor] EPLB refactoring for FusedMoE vllm#41055

  9. [Model Runner V2] Apply synthetic mode to probabilistic rejection sampler vllm#41035

  10. Revert "[Core] Replace routing replay with device cache and async D2H pipeline" (#39917) vllm#42434

Does this PR introduce any user-facing change?

How was this patch tested?

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the reference commit hash for vLLM within the project's documentation configuration. This ensures that the documentation remains aligned with the latest developments and features in the vLLM repository.

Highlights

  • Dependency Update: Updated the vLLM commit hash in the documentation configuration to point to a newer version.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (5)
    • .github/workflows/_e2e_test.yaml
    • .github/workflows/dockerfiles/Dockerfile.lint
    • .github/workflows/pr_test_full.yaml
    • .github/workflows/pr_test_light.yaml
    • .github/workflows/schedule_lint_image_build.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ci/build labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the main_vllm_commit hash in docs/source/conf.py to track a more recent version of the upstream vLLM repository. The review feedback identifies that the PR title and summary do not comply with the repository's style guide, specifically noting a missing action tag and a typo in the title, and provides a structured template for the required summary.

Comment thread docs/source/conf.py Outdated
@Potabk Potabk added ready read for review ready-for-test start test by label for PR labels May 11, 2026
@Potabk Potabk requested a review from MengqingCao as a code owner May 12, 2026 13:00
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Potabk added 8 commits May 14, 2026 00:33
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Potabk added 6 commits May 14, 2026 00:33
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Potabk added 5 commits May 14, 2026 09:16
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
@Potabk Potabk changed the title [CI] Upgrade vllm commit to 050* [CI] Upgrade vllm commit to 0512 May 14, 2026
@Potabk Potabk closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants