[Misc][Main2Main] Upgrade vLLM to v0.20.1 and 0506#8888
[Misc][Main2Main] Upgrade vLLM to v0.20.1 and 0506#8888wxsIcey wants to merge 12 commits intovllm-project:mainfrom
v0.20.1 and 0506#8888Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the underlying vLLM dependency and introduces several compatibility layers to accommodate changes in the upstream vLLM codebase. It refactors the MoE implementation by consolidating shared expert logic into the primary AscendFusedMoE class and adds version-aware logic to handle API changes in vLLM's core components. These changes ensure that the Ascend backend remains functional across different vLLM versions while maintaining performance optimizations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
upgrade to |
There was a problem hiding this comment.
Code Review
This pull request adapts the vllm-ascend plugin for compatibility with newer vLLM versions (post-v0.19.1). Key changes include refactoring the MoE implementation to merge shared expert logic into the base classes, implementing a global patching system for engine subprocesses, and adding version-specific handling for LoRA, scheduler, and worker components. It also includes an Ascend-specific patch for KV cache block size resolution to support context parallelism with multiple groups. I have no feedback to provide.\n\nSuggested PR Title:\n\nmarkdown\n[Ops][Misc] Adapt vllm-ascend for compatibility with newer vLLM versions and refactor MoE\n\n\nSuggested PR Summary:\n\nmarkdown\n### What this PR does / why we need it?\nThis PR introduces several compatibility fixes and refactorings to support vLLM versions beyond 0.19.1. Key updates include refactoring `AscendFusedMoE` and `AscendFusedMoE310` to incorporate shared expert logic directly, implementing `_ensure_global_patch` for engine-core subprocesses, and adding version-aware logic for `CompilationTimes`, `RMSNormGated`, and LoRA registration. It also patches `resolve_kv_cache_block_sizes` to support context parallelism with multiple KV cache groups on Ascend.\n\n### Does this PR introduce _any_ user-facing change?\nNo.\n\n### How was this patch tested?\nTested with updated unit tests in `tests/ut/_310p/fused_moe/`, `tests/ut/ops/test_fused_moe.py`, and `tests/ut/spec_decode/test_eagle_proposer.py`.\n
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
v0.20.1 and 0506
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
Signed-off-by: wxsIcey <1790571317@qq.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Based on #8856
Fixes
NPUInputBatchnot havethinking_budget_state_holder = None, caused by [Reasoning][Feature] Support for speculative decoding with thinking budgetFixes 'AscendMultiHeadLatentAttention' not have
skip_topk, caused by [Feature]: IndexCache support for DSA modelsFixes MLA prefill backends selection, caused by [Attention] Abstract the MLA prefill backends and eliminate cuDNN
Fixes ModelRunner V2 eagle refactor, caused by [Model Runner V2] Skip attention metadata rebuild before draft prefill
, [Model Runner V2] Rebuild attn metadata between draft decode steps
, [Model Runner V2] Add logprob_token_ids support
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI passed with new added/existing test.