[Misc] Drop vlllm 0.19.1 support#8855
Conversation
wangxiyuan
requested review from
LCAIZJ,
MengqingCao,
Yikun,
realliujiaxu,
weijinqian0,
whx-sjtu and
zzzzwwjj
as code owners
github-actions
Bot
added
documentation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request removes support for vLLM version 0.19.1 to streamline the codebase and focus on newer versions. It involves cleaning up conditional checks, updating Docker build configurations to pin a specific commit, and removing legacy import paths and logic that were previously required for compatibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR removes legacy vLLM v0.19.1 version checks and logic from Dockerfiles, tests, and core components, while updating Docker builds to use a specific commit hash. Feedback highlights a critical bug in all Dockerfiles where the VLLM_REPO argument was accidentally commented out, which will break the build process.
Suggested PR Title:
[Misc][BugFix] Remove legacy v0.19.1 version checks and fix Dockerfile build arguments
Suggested PR Summary:
### What this PR does / why we need it?
This PR removes legacy version-specific logic and checks related to vLLM v0.19.1 across the repository, including Dockerfiles, core scheduling logic, attention implementations, and end-to-end tests. It also updates the Docker build process to fetch vLLM using a specific commit hash. Critical issues were identified in all modified Dockerfiles where the VLLM_REPO argument was commented out while still being used in the RUN command, which will lead to build failures.
### Does this PR introduce _any_ user-facing change?
No. This is an internal cleanup and build configuration update.
### How was this patch tested?
The changes involve removing version-specific skips in existing tests and updating build scripts. Testing should be verified via CI build pipelines.| # ARG VLLM_REPO=https://github.com/vllm-project/vllm.git | ||
| # ARG VLLM_TAG=v0.19.1 | ||
| # RUN git clone --depth 1 -b $VLLM_TAG $VLLM_REPO /vllm-workspace/vllm | ||
| ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8 | ||
| RUN git init /vllm-workspace/vllm && \ | ||
| git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \ | ||
| git -C /vllm-workspace/vllm checkout FETCH_HEAD |
There was a problem hiding this comment.
The VLLM_REPO build argument is commented out, but it's used in the RUN command. This will cause the Docker build to fail. This suggestion restores the VLLM_REPO definition and removes the other obsolete commented-out code for better readability.
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8
RUN git init /vllm-workspace/vllm && \
git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \
git -C /vllm-workspace/vllm checkout FETCH_HEAD
| # ARG VLLM_REPO=https://github.com/vllm-project/vllm.git | ||
| # ARG VLLM_TAG=v0.19.1 | ||
| # RUN git clone --depth 1 -b $VLLM_TAG $VLLM_REPO /vllm-workspace/vllm | ||
| ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8 | ||
| RUN git init /vllm-workspace/vllm && \ | ||
| git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \ | ||
| git -C /vllm-workspace/vllm checkout FETCH_HEAD |
There was a problem hiding this comment.
The VLLM_REPO build argument is commented out, but it's used in the RUN command. This will cause the Docker build to fail. This suggestion restores the VLLM_REPO definition and removes the other obsolete commented-out code for better readability.
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8
RUN git init /vllm-workspace/vllm && \
git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \
git -C /vllm-workspace/vllm checkout FETCH_HEAD
| # ARG VLLM_REPO=https://github.com/vllm-project/vllm.git | ||
| # ARG VLLM_TAG=v0.19.1 | ||
| # RUN git clone --depth 1 -b $VLLM_TAG $VLLM_REPO /vllm-workspace/vllm | ||
| ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8 | ||
| RUN git init /vllm-workspace/vllm && \ | ||
| git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \ | ||
| git -C /vllm-workspace/vllm checkout FETCH_HEAD |
There was a problem hiding this comment.
The VLLM_REPO build argument is commented out, but it's used in the RUN command. This will cause the Docker build to fail. This suggestion restores the VLLM_REPO definition and removes the other obsolete commented-out code for better readability.
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8
RUN git init /vllm-workspace/vllm && \
git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \
git -C /vllm-workspace/vllm checkout FETCH_HEAD
| # ARG VLLM_REPO=https://github.com/vllm-project/vllm.git | ||
| # ARG VLLM_TAG=v0.19.1 | ||
| # RUN git clone --depth 1 -b $VLLM_TAG $VLLM_REPO /vllm-workspace/vllm | ||
| ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8 | ||
| RUN git init /vllm-workspace/vllm && \ | ||
| git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \ | ||
| git -C /vllm-workspace/vllm checkout FETCH_HEAD |
There was a problem hiding this comment.
The VLLM_REPO build argument is commented out, but it's used in the RUN command. This will cause the Docker build to fail. This suggestion restores the VLLM_REPO definition and removes the other obsolete commented-out code for better readability.
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8
RUN git init /vllm-workspace/vllm && \
git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \
git -C /vllm-workspace/vllm checkout FETCH_HEAD
| # ARG VLLM_REPO=https://github.com/vllm-project/vllm.git | ||
| # ARG VLLM_TAG=v0.19.1 | ||
| # RUN git clone --depth 1 -b $VLLM_TAG $VLLM_REPO /vllm-workspace/vllm | ||
| ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8 | ||
| RUN git init /vllm-workspace/vllm && \ | ||
| git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \ | ||
| git -C /vllm-workspace/vllm checkout FETCH_HEAD |
There was a problem hiding this comment.
The VLLM_REPO build argument is commented out, but it's used in the RUN command. This will cause the Docker build to fail. This suggestion restores the VLLM_REPO definition and removes the other obsolete commented-out code for better readability.
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8
RUN git init /vllm-workspace/vllm && \
git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \
git -C /vllm-workspace/vllm checkout FETCH_HEAD
| # ARG VLLM_REPO=https://github.com/vllm-project/vllm.git | ||
| # ARG VLLM_TAG=v0.19.1 | ||
| # RUN git clone --depth 1 -b $VLLM_TAG $VLLM_REPO /vllm-workspace/vllm | ||
| ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8 | ||
| RUN git init /vllm-workspace/vllm && \ | ||
| git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \ | ||
| git -C /vllm-workspace/vllm checkout FETCH_HEAD |
There was a problem hiding this comment.
The VLLM_REPO build argument is commented out, but it's used in the RUN command. This will cause the Docker build to fail. This suggestion restores the VLLM_REPO definition and removes the other obsolete commented-out code for better readability.
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
ARG VLLM_COMMIT=d886c26d4d4fef7d079696beb4ece1cfb4b008a8
RUN git init /vllm-workspace/vllm && \
git -C /vllm-workspace/vllm fetch --depth 1 $VLLM_REPO $VLLM_COMMIT && \
git -C /vllm-workspace/vllm checkout FETCH_HEAD
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
|
|
2 participants
What this PR does / why we need it?
This PR removes legacy version-specific logic and checks related to vLLM v0.19.1 across the repository, including Dockerfiles, core scheduling logic, attention implementations, and end-to-end tests. It also updates the Docker build process to fetch vLLM using a specific commit hash. Critical issues were identified in all modified Dockerfiles where the VLLM_REPO argument was commented out while still being used in the RUN command, which will lead to build failures.
Does this PR introduce any user-facing change?
No. This is an internal cleanup and build configuration update.
How was this patch tested?
The changes involve removing version-specific skips in existing tests and updating build scripts. Testing should be verified via CI build pipelines.