[Doc][0.18.0] Fix the wrong triton uninstall guide - #8672
Tflowers-0129 wants to merge 1 commit into
Conversation
Signed-off-by: Tflowers-0129 <2906339855@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request corrects a syntax error in the documentation for uninstalling Triton dependencies on Atlas 300I DUO hardware. By splitting the combined command into two distinct operations, it ensures that both packages are properly removed as intended. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request corrects a syntax error in the Atlas 300I DUO documentation where triton-ascend was incorrectly treated as a shell command during uninstallation. The reviewer suggested combining the separate pip uninstall commands into a single call for efficiency and pointed out that the PR title and summary need to be updated to follow the repository's style guide.
| pip uninstall -y triton | ||
| pip uninstall -y triton-ascend |
There was a problem hiding this comment.
The Pull Request title and summary do not adhere to the repository's style guide. Please update them to follow the required format. Additionally, the uninstallation commands can be combined into a single pip call for efficiency.
Suggested PR Title:
[0.18.0][Doc][BugFix] Fix the wrong triton uninstall guideSuggested PR Summary:
### What this PR does / why we need it?
This PR corrects the `triton` and `triton-ascend` uninstallation commands in the Atlas 300I DUO documentation. The previous command `pip uninstall -y triton && triton-ascend` was syntactically incorrect as it attempted to execute `triton-ascend` as a shell command.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Documentation update only.| pip uninstall -y triton | |
| pip uninstall -y triton-ascend | |
| pip uninstall -y triton triton-ascend |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
out-date |
What this PR does / why we need it?
Fix the guide of the triton uninstall
Does this PR introduce any user-facing change?
NA
How was this patch tested?
NA