Skip to content

[Doc][0.18.0] Fix the wrong triton uninstall guide - #8672

Closed
Tflowers-0129 wants to merge 1 commit into
vllm-project:releases/v0.18.0from
Tflowers-0129:releases/v0.18.0
Closed

Tflowers-0129 wants to merge 1 commit into
vllm-project:releases/v0.18.0from
Tflowers-0129:releases/v0.18.0

Conversation

@Tflowers-0129

@Tflowers-0129 Tflowers-0129 commented Apr 24, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it?

Fix the guide of the triton uninstall

Does this PR introduce any user-facing change?

NA

How was this patch tested?

NA

Signed-off-by: Tflowers-0129 <2906339855@qq.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request corrects a syntax error in the documentation for uninstalling Triton dependencies on Atlas 300I DUO hardware. By splitting the combined command into two distinct operations, it ensures that both packages are properly removed as intended.

Highlights

  • Documentation Correction: Updated the Triton uninstallation commands in the Atlas 300I DUO tutorial to correctly execute as two separate pip commands.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a syntax error in the Atlas 300I DUO documentation where triton-ascend was incorrectly treated as a shell command during uninstallation. The reviewer suggested combining the separate pip uninstall commands into a single call for efficiency and pointed out that the PR title and summary need to be updated to follow the repository's style guide.

Comment on lines +18 to +19
pip uninstall -y triton
pip uninstall -y triton-ascend

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Pull Request title and summary do not adhere to the repository's style guide. Please update them to follow the required format. Additionally, the uninstallation commands can be combined into a single pip call for efficiency.

Suggested PR Title:

[0.18.0][Doc][BugFix] Fix the wrong triton uninstall guide

Suggested PR Summary:

### What this PR does / why we need it?

This PR corrects the `triton` and `triton-ascend` uninstallation commands in the Atlas 300I DUO documentation. The previous command `pip uninstall -y triton && triton-ascend` was syntactically incorrect as it attempted to execute `triton-ascend` as a shell command.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Documentation update only.
Suggested change
pip uninstall -y triton
pip uninstall -y triton-ascend
pip uninstall -y triton triton-ascend
References
  1. The PR title must follow the format [Branch][Module][Action] Pull Request Title. (link)
  2. The PR summary must follow the specified markdown template. (link)

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tflowers-0129

Copy link
Copy Markdown
Collaborator Author

out-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant