[BugFix][310p] Align 310P GDN state semantics with vLLM - #7902
Conversation
Signed-off-by: Tflowers-0129 <2906339855@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aligns the 310P GDN state semantics with vLLM by adjusting the state layout and refactoring L2 normalization to use standard library functions. These changes ensure consistency across the codebase and prepare for upcoming operator updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This PR aligns the state layout of Gated Delta Rule (GDN) operations with vLLM by swapping the K and V dimensions in state tensors. Feedback focuses on maintaining numerical stability by avoiding F.normalize in favor of an explicit L2 norm with a larger epsilon for float16 compatibility, and correcting the PR title format.
Suggested PR Title:
[310p][Ops][BugFix] Align 310P GDN state semantics with vLLMSuggested PR Summary:
### What this PR does / why we need it?
This PR aligns the state layout of Gated Delta Rule (GDN) operations (chunked and fused recurrent) with vLLM's expected semantics by changing state shapes from `[..., K, V]` to `[..., V, K]`. This ensures consistency with reference FLA kernels.
Feedback was provided to revert the change from manual L2 normalization to `torch.nn.functional.normalize`, as the latter's default epsilon (1e-12) is too small for `float16` stability.
### Does this PR introduce _any_ user-facing change?
Yes, the expected shape of the `initial_state` tensor for GDN operations has changed.
### How was this patch tested?
Tested via updated unit tests and new parity tests verifying state layout against vLLM reference values.…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com> (cherry picked from commit dbf9f7a)
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com> Signed-off-by: guxin108 <1252896542@qq.com>
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com>
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com> Signed-off-by: zouyida2052 <zouyida2002@gmail.com>
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com>
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com> Signed-off-by: nanxing <1014662416@qq.com>
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com>
…#7902) ### What this PR does / why we need it? - I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is `[N, HV, V, K]`, while in vllm-ascend it is `[N, HV, K, V]`. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide a ` fused recurrent-gated-delta-rule` operator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance. - I also found that L2 normalization can use the operator provided in `functional`, instead of being fully implemented through manually stitched small ops as it is now. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? ut and the e2e test - vLLM version: v0.18.0 - vLLM main: vllm-project/vllm@35141a7 --------- Signed-off-by: Tflowers-0129 <2906339855@qq.com>
What this PR does / why we need it?
I found that the FLA state semantics are not aligned between vllm-ascend and vLLM: in vLLM, the state layout is
[N, HV, V, K], while in vllm-ascend it is[N, HV, K, V]. The early 310P implementation was aligned with the mainline vllm-ascend behavior, but the operator team now plans to provide afused recurrent-gated-delta-ruleoperator whose semantics will align with vLLM. Therefore, this needs to be adjusted in advance.I also found that L2 normalization can use the operator provided in
functional, instead of being fully implemented through manually stitched small ops as it is now.Does this PR introduce any user-facing change?
NA
How was this patch tested?
ut and the e2e test