[v0.13.0][bugfix][accuracy] Fix ds indexer accuracy problem caused by k rope#7859
[v0.13.0][bugfix][accuracy] Fix ds indexer accuracy problem caused by k rope#7859rjg-lyh wants to merge 1 commit intovllm-project:releases/v0.13.0from
Conversation
… k rope Signed-off-by: rjg-lyh <1318825571@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an accuracy regression in the DeepSeek indexer component. By correcting the rotary embedding application method to align with the expected NeoX-style implementation, the patch ensures consistent and accurate model behavior, resolving an issue introduced by a previous code reversion. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
Suggested PR Title:\n\nmarkdown\n[Attention][Misc] Update rotary embedding function in sfa_v1\n\n\nSuggested PR Summary:\n\nmarkdown\n### What this PR does / why we need it?\nThis PR updates the `indexer_select_pre_process` function in `vllm_ascend/attention/sfa_v1.py` by replacing the `torch_npu.npu_interleave_rope` call with `torch_npu.npu_rotary_mul`. This change ensures the attention mechanism uses the correct rotary multiplication operation for the key positional embeddings.\n\n### Does this PR introduce _any_ user-facing change?\nNo.\n\n### How was this patch tested?\nCI passed with existing tests.\n\n\nI have no feedback to provide.
What this PR does / why we need it?
The rotary algorithm in deepseek indexer should be neox-style instead of gptj style. PR #4641 fix this accuracy bug in original pytorch version. But PR #5701 accidentally removed the fixed code line and reverted the implementation back to the problematic version. This PR fixes it.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed with new added/existing test.