Skip to content

Main2main upgrade vllm commit to 03 19 17:00#7478

Merged
wangxiyuan merged 10 commits intovllm-project:mainfrom
leo-pony:main2main_0319
Mar 23, 2026
Merged

Main2main upgrade vllm commit to 03 19 17:00#7478
wangxiyuan merged 10 commits intovllm-project:mainfrom
leo-pony:main2main_0319

Conversation

@leo-pony
Copy link
Copy Markdown
Collaborator

@leo-pony leo-pony commented Mar 19, 2026

What this PR does / why we need it?

Upgrade vllm commit to 2026.03.19.

1.Fix socket removed from StatelessProcessGroup. Upstream vLLM PR #36330 ("elastic_ep: Fix stateless group port races") refactored StatelessProcessGroup and removed the socket: socket.socket | None field. The socket ownership was moved to a new create_tcp_store() helper instead of being stored as a field on the dataclass.

2.fix virtual_engine parameter removed from `set_forward_context(). Upstream [V0 Deprecation] Deprecate virtual engine #37195

Does this PR introduce any user-facing change?

NA

How was this patch tested?

NA

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the versioning_policy.md documentation to align with the latest main branch compatibility for vLLM Ascend. The change specifically refreshes the referenced vLLM commit hash, ensuring that the documented versioning information accurately reflects the current development state.

Highlights

  • Documentation Update: The versioning_policy.md file was updated to reflect a new vLLM commit hash (6a9cceb219fcbd6b1eb540ddfdc77ec160f0e209), ensuring the compatibility table remains current.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/_e2e_test.yaml
    • .github/workflows/bot_pr_create.yaml
    • .github/workflows/dockerfiles/Dockerfile.lint
    • .github/workflows/pr_test_full.yaml
    • .github/workflows/pr_test_light.yaml
    • .github/workflows/schedule_codecov_refresh.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates a vLLM commit hash in the docs/source/community/versioning_policy.md file, specifically changing the commit hash for the main branch's compatibility with vLLM. This is a minor documentation update. However, the pull request title and description do not adhere to the repository's defined style guide for pull request formatting. The PR title should follow the format [Branch][Module][Action] Pull Request Title, for example: [main][Doc][Misc] Upgrade vLLM commit hash in versioning policy. The PR summary should be filled out according to the template provided in the style guide, detailing what the PR does, why it's needed, if it introduces user-facing changes, and how it was tested.

@github-actions github-actions bot added documentation Improvements or additions to documentation ci/build labels Mar 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@leo-pony leo-pony added ready read for review ready-for-test start test by label for PR labels Mar 19, 2026
@leo-pony leo-pony force-pushed the main2main_0319 branch 2 times, most recently from 5900db1 to 5883a61 Compare March 20, 2026 03:42
@leo-pony leo-pony removed ready read for review ready-for-test start test by label for PR labels Mar 20, 2026
@leo-pony leo-pony added ready read for review ready-for-test start test by label for PR labels Mar 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
…astic_ep: Fix stateless group port races, commit de1a86b7d) refactored StatelessProcessGroup and removed the socket: socket.socket | None field.

The socket ownership was moved to a new create_tcp_store() helper instead of being stored as a field on the dataclass.
Fix: Removed the now-invalid socket=None keyword argument from the StatelessProcessGroup

Signed-off-by: leo-pony <nengjunma@outlook.com>
…tual engine #37195) removed the virtual_engine parameter from set_forward_context(), create_forward_context(), and the ForwardContext dataclass.

This broke vllm-ascend which was passing virtual_engine in kwargs and accessing forward_context.virtual_engine

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
@leo-pony leo-pony force-pushed the main2main_0319 branch 2 times, most recently from 86e1250 to 79e1a8c Compare March 23, 2026 03:48
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
@wangxiyuan wangxiyuan merged commit 8e2c59e into vllm-project:main Mar 23, 2026
38 checks passed
starmountain1997 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Mar 25, 2026
### What this PR does / why we need it?
Upgrade vllm commit to 2026.03.19.

1.Fix socket removed from StatelessProcessGroup. Upstream vLLM PR
[#36330](vllm-project/vllm#36330) ("elastic_ep:
Fix stateless group port races") refactored StatelessProcessGroup and
removed the socket: socket.socket | None field. The socket ownership was
moved to a new create_tcp_store() helper instead of being stored as a
field on the dataclass.

2.fix `virtual_engine` parameter removed from `set_forward_context().
Upstream [V0 Deprecation] Deprecate virtual engine
[#37195](vllm-project/vllm#37195)

### Does this PR introduce _any_ user-facing change?
NA

### How was this patch tested?
NA

- vLLM version: v0.17.0
- vLLM main:
vllm-project/vllm@8b63257

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
lihaokun-2026 pushed a commit to lihaokun-2026/vllm-ascend that referenced this pull request Mar 29, 2026
### What this PR does / why we need it?
Upgrade vllm commit to 2026.03.19.

1.Fix socket removed from StatelessProcessGroup. Upstream vLLM PR
[#36330](vllm-project/vllm#36330) ("elastic_ep:
Fix stateless group port races") refactored StatelessProcessGroup and
removed the socket: socket.socket | None field. The socket ownership was
moved to a new create_tcp_store() helper instead of being stored as a
field on the dataclass.

2.fix `virtual_engine` parameter removed from `set_forward_context().
Upstream [V0 Deprecation] Deprecate virtual engine
[#37195](vllm-project/vllm#37195)

### Does this PR introduce _any_ user-facing change?
NA

### How was this patch tested?
NA

- vLLM version: v0.17.0
- vLLM main:
vllm-project/vllm@8b63257

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
chenchuw886 pushed a commit to chenchuw886/vllm-ascend that referenced this pull request Apr 1, 2026
### What this PR does / why we need it?
Upgrade vllm commit to 2026.03.19.

1.Fix socket removed from StatelessProcessGroup. Upstream vLLM PR
[#36330](vllm-project/vllm#36330) ("elastic_ep:
Fix stateless group port races") refactored StatelessProcessGroup and
removed the socket: socket.socket | None field. The socket ownership was
moved to a new create_tcp_store() helper instead of being stored as a
field on the dataclass.

2.fix `virtual_engine` parameter removed from `set_forward_context().
Upstream [V0 Deprecation] Deprecate virtual engine
[#37195](vllm-project/vllm#37195)

### Does this PR introduce _any_ user-facing change?
NA

### How was this patch tested?
NA

- vLLM version: v0.17.0
- vLLM main:
vllm-project/vllm@8b63257

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants