[EPLB][Bugfix] Set parallel_config.enable_eplb to true to load redundant experts#7470
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug where the system was not correctly loading redundant experts due to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the bug by introducing self.eplb_enable to centralize the EPLB enablement logic and then using this flag to set self.vllm_config.parallel_config.enable_eplb = True during model loading. This ensures that redundant experts are loaded when EPLB is active, aligning with the PR's objective.
8ca95ae to
d2c61fb
Compare
d2c61fb to
36cc9d1
Compare
…ant experts. Signed-off-by: shenchuxiaofugui <1311027364@qq.com>
36cc9d1 to
d99716d
Compare
…ant experts (vllm-project#7470) ### What this PR does / why we need it? pr: vllm-project/vllm#37136 break eplb because it filters out redundant experts. pr: vllm-project/vllm#37322 fix it due to use parallel_config.enable_eplb to determine whether to skip the weight loading filter. But in vllm-ascend, parallel_config.enable_eplb is always false. When we use eplb, we temporarily set it to true. ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as API, interface or other behavior changes. Documentation-only updates are not considered user-facing changes. --> ### How was this patch tested?  | dataset | version | metric | mode | vllm-api-stream-chat | |----- | ----- | ----- | ----- | -----| | aime2024 | 604a78 | accuracy | gen | 86.67 | Signed-off-by: shenchuxiaofugui <1311027364@qq.com>
…ant experts (vllm-project#7470) ### What this PR does / why we need it? pr: vllm-project/vllm#37136 break eplb because it filters out redundant experts. pr: vllm-project/vllm#37322 fix it due to use parallel_config.enable_eplb to determine whether to skip the weight loading filter. But in vllm-ascend, parallel_config.enable_eplb is always false. When we use eplb, we temporarily set it to true. ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as API, interface or other behavior changes. Documentation-only updates are not considered user-facing changes. --> ### How was this patch tested?  | dataset | version | metric | mode | vllm-api-stream-chat | |----- | ----- | ----- | ----- | -----| | aime2024 | 604a78 | accuracy | gen | 86.67 | Signed-off-by: shenchuxiaofugui <1311027364@qq.com>
…ant experts (vllm-project#7470) ### What this PR does / why we need it? pr: vllm-project/vllm#37136 break eplb because it filters out redundant experts. pr: vllm-project/vllm#37322 fix it due to use parallel_config.enable_eplb to determine whether to skip the weight loading filter. But in vllm-ascend, parallel_config.enable_eplb is always false. When we use eplb, we temporarily set it to true. ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as API, interface or other behavior changes. Documentation-only updates are not considered user-facing changes. --> ### How was this patch tested?  | dataset | version | metric | mode | vllm-api-stream-chat | |----- | ----- | ----- | ----- | -----| | aime2024 | 604a78 | accuracy | gen | 86.67 | Signed-off-by: shenchuxiaofugui <1311027364@qq.com>
What this PR does / why we need it?
pr: vllm-project/vllm#37136 break eplb because it filters out redundant experts.
pr: vllm-project/vllm#37322 fix it due to use parallel_config.enable_eplb to determine whether to skip the weight loading filter.
But in vllm-ascend, parallel_config.enable_eplb is always false. When we use eplb, we temporarily set it to true.
Does this PR introduce any user-facing change?
How was this patch tested?