Skip to content

[CI]Style: Convert test/ to ruff format(Batch #7)#7437

Merged
wangxiyuan merged 2 commits intovllm-project:mainfrom
MrZ20:lint-test-7
Apr 20, 2026
Merged

[CI]Style: Convert test/ to ruff format(Batch #7)#7437
wangxiyuan merged 2 commits intovllm-project:mainfrom
MrZ20:lint-test-7

Conversation

@MrZ20
Copy link
Copy Markdown
Contributor

@MrZ20 MrZ20 commented Mar 18, 2026

What this PR does / why we need it?

File Path
tests/ut/kv_connector/test_mooncake_connector.py
tests/ut/kv_connector/test_mooncake_layerwise_connector.py
tests/ut/kv_connector/test_remote_decode_lifecycle.py
tests/ut/kv_connector/test_remote_prefill_lifecycle.py
tests/ut/kv_connector/utils.py
tests/ut/model_loader/netloader/test_netloader.py
tests/ut/model_loader/netloader/test_netloader_elastic.py
tests/ut/model_loader/netloader/test_netloader_load.py
tests/ut/model_loader/netloader/test_netloader_utils.py

Does this PR introduce any user-facing change?

How was this patch tested?

@MrZ20 MrZ20 requested a review from wangxiyuan as a code owner March 18, 2026 11:34
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request continues the ongoing effort to standardize the codebase's style by applying ruff linting to a new batch of unit test files. The changes primarily involve automated formatting adjustments to ensure consistency and adherence to established coding standards, thereby improving code quality and maintainability.

Highlights

  • Ruff Linting Expansion: Expanded the scope of ruff linting to include additional test files and subdirectories within the tests/ut/ path, as reflected in the pyproject.toml configuration.
  • Code Style Standardization: Applied automated code style fixes across numerous Python test files to conform with ruff formatting rules, addressing issues such as import ordering, whitespace, line breaks, and dictionary/argument formatting.
  • Improved Readability and Consistency: Enhanced the overall readability and consistency of the affected test files by standardizing code layout and syntax, making them easier to review and maintain.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies ruff formatting to a batch of files in the tests/ directory. The changes primarily consist of style adjustments such as reordering imports, reformatting long lines, updating type hints to modern syntax, and standardizing quotes and spacing. I have reviewed the changes across all modified files and they appear to be correct and consistent with the goal of applying automated formatting. I did not find any functional issues or bugs that would warrant a high or critical severity comment.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@MrZ20 MrZ20 force-pushed the lint-test-7 branch 3 times, most recently from c71b155 to 5c5ceff Compare March 23, 2026 12:24
@MrZ20 MrZ20 changed the title [Lint]Style: Convert test/ to ruff format(Batch #7) [CI]Style: Convert test/ to ruff format(Batch #7) Apr 3, 2026
@MrZ20 MrZ20 force-pushed the lint-test-7 branch 2 times, most recently from 06b2944 to b24d72f Compare April 10, 2026 08:12
@Potabk Potabk added ready read for review ready-for-test start test by label for PR labels Apr 20, 2026
Signed-off-by: MrZ20 <2609716663@qq.com>
Signed-off-by: MrZ20 <2609716663@qq.com>
@wangxiyuan wangxiyuan merged commit b62f0d1 into vllm-project:main Apr 20, 2026
37 checks passed
@MrZ20 MrZ20 deleted the lint-test-7 branch April 21, 2026 03:13
tfhddd pushed a commit to ascend-gha-runners/vllm-ascend that referenced this pull request Apr 21, 2026
### What this PR does / why we need it?
| File Path |
| :--- |
| `tests/ut/kv_connector/test_mooncake_connector.py` |
| `tests/ut/kv_connector/test_mooncake_layerwise_connector.py` |
| `tests/ut/kv_connector/test_remote_decode_lifecycle.py` |
| `tests/ut/kv_connector/test_remote_prefill_lifecycle.py` |
| `tests/ut/kv_connector/utils.py` |
| `tests/ut/model_loader/netloader/test_netloader.py` |
| `tests/ut/model_loader/netloader/test_netloader_elastic.py` |
| `tests/ut/model_loader/netloader/test_netloader_load.py` |
| `tests/ut/model_loader/netloader/test_netloader_utils.py` |

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.17.0
- vLLM main:
vllm-project/vllm@4497431

---------

Signed-off-by: MrZ20 <2609716663@qq.com>
Signed-off-by: tfhddd <2272751277@qq.com>
anning-2026 pushed a commit to anning-2026/vllm-ascend that referenced this pull request Apr 21, 2026
…-project#7437)

### What this PR does / why we need it?
| File Path |
| :--- |
| `tests/ut/kv_connector/test_mooncake_connector.py` |
| `tests/ut/kv_connector/test_mooncake_layerwise_connector.py` |
| `tests/ut/kv_connector/test_remote_decode_lifecycle.py` |
| `tests/ut/kv_connector/test_remote_prefill_lifecycle.py` |
| `tests/ut/kv_connector/utils.py` |
| `tests/ut/model_loader/netloader/test_netloader.py` |
| `tests/ut/model_loader/netloader/test_netloader_elastic.py` |
| `tests/ut/model_loader/netloader/test_netloader_load.py` |
| `tests/ut/model_loader/netloader/test_netloader_utils.py` |

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.17.0
- vLLM main:
vllm-project/vllm@4497431

---------

Signed-off-by: MrZ20 <2609716663@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants