[CI]Style: Convert test/ to ruff format(Batch #7)#7437
[CI]Style: Convert test/ to ruff format(Batch #7)#7437wangxiyuan merged 2 commits intovllm-project:mainfrom
test/ to ruff format(Batch #7)#7437Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request continues the ongoing effort to standardize the codebase's style by applying Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request applies ruff formatting to a batch of files in the tests/ directory. The changes primarily consist of style adjustments such as reordering imports, reformatting long lines, updating type hints to modern syntax, and standardizing quotes and spacing. I have reviewed the changes across all modified files and they appear to be correct and consistent with the goal of applying automated formatting. I did not find any functional issues or bugs that would warrant a high or critical severity comment.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
c71b155 to
5c5ceff
Compare
test/ to ruff format(Batch #7)test/ to ruff format(Batch #7)
06b2944 to
b24d72f
Compare
### What this PR does / why we need it? | File Path | | :--- | | `tests/ut/kv_connector/test_mooncake_connector.py` | | `tests/ut/kv_connector/test_mooncake_layerwise_connector.py` | | `tests/ut/kv_connector/test_remote_decode_lifecycle.py` | | `tests/ut/kv_connector/test_remote_prefill_lifecycle.py` | | `tests/ut/kv_connector/utils.py` | | `tests/ut/model_loader/netloader/test_netloader.py` | | `tests/ut/model_loader/netloader/test_netloader_elastic.py` | | `tests/ut/model_loader/netloader/test_netloader_load.py` | | `tests/ut/model_loader/netloader/test_netloader_utils.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4497431 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Signed-off-by: tfhddd <2272751277@qq.com>
…-project#7437) ### What this PR does / why we need it? | File Path | | :--- | | `tests/ut/kv_connector/test_mooncake_connector.py` | | `tests/ut/kv_connector/test_mooncake_layerwise_connector.py` | | `tests/ut/kv_connector/test_remote_decode_lifecycle.py` | | `tests/ut/kv_connector/test_remote_prefill_lifecycle.py` | | `tests/ut/kv_connector/utils.py` | | `tests/ut/model_loader/netloader/test_netloader.py` | | `tests/ut/model_loader/netloader/test_netloader_elastic.py` | | `tests/ut/model_loader/netloader/test_netloader_load.py` | | `tests/ut/model_loader/netloader/test_netloader_utils.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.17.0 - vLLM main: vllm-project/vllm@4497431 --------- Signed-off-by: MrZ20 <2609716663@qq.com>
What this PR does / why we need it?
tests/ut/kv_connector/test_mooncake_connector.pytests/ut/kv_connector/test_mooncake_layerwise_connector.pytests/ut/kv_connector/test_remote_decode_lifecycle.pytests/ut/kv_connector/test_remote_prefill_lifecycle.pytests/ut/kv_connector/utils.pytests/ut/model_loader/netloader/test_netloader.pytests/ut/model_loader/netloader/test_netloader_elastic.pytests/ut/model_loader/netloader/test_netloader_load.pytests/ut/model_loader/netloader/test_netloader_utils.pyDoes this PR introduce any user-facing change?
How was this patch tested?