-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Doc] fix DSV3.1 PD configs #7187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change correctly makes the
engine_idconsistent for the logical decoder engine. However, thekv_portvalues used throughout this document appear to conflict with the guidance inpd_disaggregation_mooncake_multi_node.md.For 16-NPU nodes like the Atlas 800 A3, that guide recommends
kv_port >= 36000to avoid port conflicts with AscendDirectTransport, which can causezmq.error.ZMQError: Address already in use. The ports30000,30100, and30200used in this document are within the reserved range.I recommend updating all
kv_portvalues in this file to follow that guidance. For example, you could use36000and36100for the prefill nodes, and36200for the decode nodes.Here is a suggested change for this block. Please apply similar changes to the other nodes' configurations in this file.