Skip to content

Revert "[CI] fix skiped e2e test when upgrade vllm version (#6654)" #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MengqingCao merged 1 commit into from
Mar 11, 2026
Merged

Revert "[CI] fix skiped e2e test when upgrade vllm version (#6654)" #7166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/multicard/2-cards/test_aclgraph_capture_replay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def _run_worker_process(
torch.npu.reset_peak_memory_stats()


@pytest.mark.skip(reason="fix me")

@gemini-code-assist gemini-code-assist Bot Mar 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While skipping a test can be a necessary temporary measure, the reason 'fix me' is too generic and makes it difficult to track the problem. Please provide a more descriptive reason, mentioning that this is a revert and why the test is failing. It is also best practice to create and link a tracking issue to ensure the test is re-enabled later.

Suggested change
@pytest.mark.skip(reason="fix me")
@pytest.mark.skip(reason="Reverting commit f6db47f. Test is failing after vLLM upgrade and needs investigation.")

@pytest.mark.parametrize("model", MODELS)
@pytest.mark.parametrize("max_tokens", [4, 36])
@patch.dict(os.environ, {"ASCEND_RT_VISIBLE_DEVICES": "0,1"})
Expand Down
Loading