fix: adapt to upstream vLLM changes (2026-03-02)#6911
fix: adapt to upstream vLLM changes (2026-03-02)#6911Meihan-chen wants to merge 2 commits intovllm-project:mainfrom
Conversation
Root causes: - CudagraphDispatcher.dispatch() disable_full replaced with valid_modes/invalid_modes (PR #34102) - compile_or_warm_up_model() now returns float compilation_time (PR #35503) - MMEncoderAttention forward methods added sequence_lengths param (PR #35564) - Removed auto-forcing of +rms_norm for sequence parallelism (PR #35410) Upstream commit range: 15d76f7..6290470 Co-Authored-By: Claude Code <noreply@anthropic.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves CI failures in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adapts the codebase to recent upstream changes in vLLM. The modifications address API and behavior changes related to the CUDAGraph dispatcher, model compilation/warm-up, multi-modal attention, and sequence parallelism. The changes are necessary for compatibility and appear to be implemented correctly. I have no further feedback.
4a70de5 to
7e84055
Compare
Root causes: - CudagraphDispatcher.dispatch() API changed: disable_full -> valid_modes/invalid_modes (#34102) - compile_or_warm_up_model() must return float compilation_time (#35503) - MMEncoderAttention.forward_oot() gained new sequence_lengths param (#34580) - +rms_norm no longer auto-forced for SP, breaks Ascend without CUDA _C ops (#35410) Upstream commit range: 15d76f7..6290470 Co-Authored-By: Claude Code <noreply@anthropic.com>
7e84055 to
a8129ff
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Summary
Fixes CI failures in schedule_test_vllm_main caused by upstream vLLM changes.
Commit range:
15d76f74e2fdb12a95ea00f0ca283acf6219a2b7..6290470843c131681e3e1318ae71070a34f33225Issues Fixed
disable_fullparam replaced withvalid_modes/invalid_modesAPI (PR #34102)floatcompilation_time (PR #35503)sequence_lengthsparam added (PR #35564)+rms_normremoved upstream, re-added in platform.py (PR #35410)Issues Skipped (Environment Flakes)
Test plan
🤖 Generated with Claude Code