Conversation
Summary of ChangesHello @MrZ20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on adapting the codebase to align with a newer vLLM version, specifically addressing changes related to version 0.15.0. It updates documentation, manages new dependencies, and implements conditional logic to maintain compatibility and correct functionality for Mixture of Experts (MoE) operations and testing across different vLLM base versions. The changes ensure that the system can gracefully handle variations in the vLLM API and internal structures. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be a synchronization effort to align with a newer version of vLLM (post-v0.15.0), introducing backward compatibility shims primarily for MoE functionality. While the changes are generally sound for a version upgrade, I have identified two high-severity issues. First, a local import in vllm_ascend/utils.py creates a circular dependency, which is a significant maintainability concern. Second, a test case appears to have been removed from tests/e2e/singlecard/test_aclgraph_accuracy.py without explanation, potentially reducing test coverage.
Additionally, as per the repository's style guide, the pull request title and description do not follow a specific format. I've provided suggestions below to align with the guidelines.
Suggested PR Title:
[main2main][Misc] Upgrade to support newer vLLM versions
Suggested PR Summary:
### What this PR does / why we need it?
This pull request introduces changes to ensure compatibility with a newer version of vLLM while maintaining backward compatibility with vLLM v0.15.0.
Key changes include:
- Adding `torchaudio` to `requirements.txt`.
- Updating the vLLM commit hash in the versioning policy documentation.
- Introducing version-based conditional logic (`if not vllm_version_is("0.15.0")`) in `vllm_ascend/ops/fused_moe/fused_moe.py` to support the new MoE runner architecture in recent vLLM versions.
- Updating e2e tests with version-specific golden answers to handle model output changes.
- Refactoring `vllm_ascend/utils.py` to handle different model config structures between vLLM versions.
These changes are necessary to keep the `vllm-ascend` plugin aligned with the upstream vLLM repository.
### Does this PR introduce _any_ user-facing change?
No user-facing changes are introduced. This is primarily a maintenance and compatibility update.
### How was this patch tested?
The changes are validated by existing CI tests. E2E tests have been updated to account for version-specific differences.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gcanlin
left a comment
There was a problem hiding this comment.
Recover all if not vllm_version_is("v0.15.0") And replace them as the following code:
if not vllm_version_is("v0.16.0"):|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
|
@MrZ20 Please set this PR to ready. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
This PR completes the parallel alignment of the vLLM Ascend main branch with the upstream vLLM branch:
(1)Aligned to vLLM v0.16.0 (tag)
(2)Aligned to the upstream vLLM commit of 2026/02/14: b3c14229b032a8bbf93d450a52c9a404ddaea429
Does this PR introduce any user-facing change?
How was this patch tested?