[BugFix][v0.13.0] fix a bug that patch from PR #5786 does not take effect

[Angazenn]

What this PR does / why we need it?

This pr corrects the patch from #5786, otherwise it might not take effect when tp_size > 1.

Related changes in this patch has been merged in vLLM #31944.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

[gemini-code-assist]

Summary of Changes

Hello @Angazenn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug preventing a critical patch from PR #5786 from being consistently applied. The fix ensures that the patch_model_runner is always active by relocating its import, thereby guaranteeing its intended behavior across all configurations.

Highlights

• Unconditional Patch Application: The patch_model_runner is now unconditionally imported and applied by moving its import statement from a conditional block in vllm_ascend/platform.py to the vllm_ascend/patch/worker/__init__.py file.
• Bug Fix for PR [v0.13.0][Bugfix] Support ALL D-Nodes in fullgraph when running MTP in PD #5786: This change addresses a bug where the patch introduced in PR [v0.13.0][Bugfix] Support ALL D-Nodes in fullgraph when running MTP in PD #5786 was not consistently taking effect due to its conditional import, ensuring its intended functionality is always active.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• vllm_ascend/patch/worker/init.py
  • Added an import statement for patch_model_runner to ensure it is always loaded.
• vllm_ascend/platform.py
  • Removed the conditional import of patch_model_runner, which previously restricted its application based on speculative_config and kv_transfer_config.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where a patch for GPUModelRunner._update_states was not being applied correctly. The patch import was previously located in a conditional block within the platform configuration code, which runs in the driver process. This change relocates the import to the worker initialization module, ensuring the patch is applied unconditionally in all worker processes. This is the correct location for worker-side patches and ensures the fix from PR #5786 takes effect as intended.