Skip to content

[CI][Misc] Some improvement for github action#6587

Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom
wangxiyuan:ci_improve
Feb 6, 2026
Merged

[CI][Misc] Some improvement for github action#6587
wangxiyuan merged 1 commit intovllm-project:mainfrom
wangxiyuan:ci_improve

Conversation

@wangxiyuan
Copy link
Copy Markdown
Collaborator

@wangxiyuan wangxiyuan commented Feb 6, 2026

What this PR does / why we need it?

  • This PR removes several self-hosted runner labels from the actionlint.yaml configuration file. These runners are likely no longer in use, so this change cleans up the configuration and ensures actionlint has an accurate list of available runners.
  • Move all Action dockerfiles to one folder
  • remove useless runner input for e2e test.
  • update workflow option version

Does this PR introduce any user-facing change?

No.

How was this patch tested?

This is a configuration change for the CI linter. The correctness will be verified by actionlint running in CI on subsequent pull requests.

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@wangxiyuan wangxiyuan requested a review from Yikun as a code owner February 6, 2026 03:00
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @wangxiyuan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Continuous Integration (CI) setup by updating the list of available self-hosted runner labels. The changes primarily involve removing several specific runner labels from the actionlint.yaml configuration, streamlining the CI environment by eliminating references to runners that are likely no longer in use or are being deprecated.

Highlights

  • Runner Label Cleanup: Removed several specific linux-aarch64-a2-* self-hosted runner labels from the CI configuration.
  • Runner Label Removal: The ubuntu-24.04-arm self-hosted runner label has been removed.
  • AMD64 Runner Label Update: Cleaned up linux-amd64-cpu-* self-hosted runner labels from the CI configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/actionlint.yaml
    • Removed linux-aarch64-a2-0, linux-aarch64-a2-1, linux-aarch64-a2-2, linux-aarch64-a2-4, linux-aarch64-a2-8 from the self-hosted-runner.labels list.
    • Removed ubuntu-24.04-arm from the self-hosted-runner.labels list.
    • Removed linux-amd64-cpu-0, linux-amd64-cpu-8, linux-amd64-cpu-16 from the self-hosted-runner.labels list.
Ignored Files
  • Ignored by pattern: .github/workflows/** (10)
    • .github/workflows/_e2e_test.yaml
    • .github/workflows/dockerfiles/Dockerfile.buildwheel
    • .github/workflows/dockerfiles/Dockerfile.nightly.a2
    • .github/workflows/dockerfiles/Dockerfile.nightly.a3
    • .github/workflows/pr_test_full.yaml
    • .github/workflows/pr_test_light.yaml
    • .github/workflows/schedule_image_build_and_push.yaml
    • .github/workflows/schedule_nightly_image_build.yaml
    • .github/workflows/schedule_release_code_and_wheel.yml
    • .github/workflows/schedule_test_vllm_main.yaml
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2026

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several self-hosted runner labels from the .github/actionlint.yaml configuration. While the change itself seems straightforward, the pull request description is empty and the title is generic. According to the repository's style guide, a descriptive title and a filled-out summary are required to provide context for reviewers. This is a high-severity issue as it hinders the review process.

To adhere to the contribution guidelines, please update the pull request. Here are suggestions for the title and summary, as formatted in the style guide:

Suggested PR Title:

[CI][Misc] Remove obsolete runner labels from actionlint config

Suggested PR Summary:

### What this PR does / why we need it?

This PR removes several self-hosted runner labels from the `actionlint.yaml` configuration file. These runners are likely no longer in use, so this change cleans up the configuration and ensures `actionlint` has an accurate list of available runners.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This is a configuration change for the CI linter. The correctness will be verified by `actionlint` running in CI on subsequent pull requests.

@wangxiyuan wangxiyuan changed the title [CI] CI enhancement [CI][Misc] Remove obsolete runner labels from actionlint config Feb 6, 2026
@wangxiyuan wangxiyuan changed the title [CI][Misc] Remove obsolete runner labels from actionlint config [CI][Misc] Some improvement for github action Feb 6, 2026
@wangxiyuan wangxiyuan merged commit d0bc168 into vllm-project:main Feb 6, 2026
22 checks passed
845473182 pushed a commit to 845473182/vllm-ascend that referenced this pull request Feb 9, 2026
…to qwen3next_rebase

* 'main' of https://github.com/vllm-project/vllm-ascend:
  [Patch] Remove the patch of MiniCPM (vllm-project#5975)
  [P/D] layerwise connector support recompute scheduler (vllm-project#5900)
  [CI] Add workflow support for lint image build (vllm-project#6489)
  [Bugfix] Fix problematic dummy_run & improper input_batch_size in eagle (vllm-project#6517)
  [Refactor]310p_e2e test case update (vllm-project#6539)
  [Refactor]refactor p2p connector (vllm-project#6551)
  [Refactor]refactor 310p attention impl and add ut (vllm-project#6579)
  [Refactor]refactor 310p ops and add ut (vllm-project#6591)
  [Ops][Refactor] Remove custom rotary_embedding operator (vllm-project#6523)
  [Lint]Style: Convert `vllm-ascend/` to ruff format(new Batch vllm-project#8) (vllm-project#6604)
  [Test] Add initial multi modal cases of Qwen2.5-VL-7B-Instruct for disaggregated encoder  (vllm-project#5301)
  [CI] Fix broken CI (vllm-project#6599)
  [Lint]Style: Convert `vllm-ascend/` to ruff format(Batch vllm-project#10) (vllm-project#6173)
  [Lint]Style: Convert `vllm-ascend/` to ruff format(Batch vllm-project#11) (vllm-project#6176)
  [Lint]Style: Convert `vllm-ascend/` to ruff format(Batch vllm-project#8) (vllm-project#6129)
  [Lint]Style: Convert `vllm-ascend/` to ruff format(Batch vllm-project#7) (vllm-project#6023)
  [CI][Misc] Some improvement for github action (vllm-project#6587)
  [Image] Bump mooncake version to v0.3.8.post1 (vllm-project#6428)
chenchuw886 pushed a commit to chenchuw886/vllm-ascend that referenced this pull request Feb 12, 2026
### What this PR does / why we need it?

- This PR removes several self-hosted runner labels from the
`actionlint.yaml` configuration file. These runners are likely no longer
in use, so this change cleans up the configuration and ensures
`actionlint` has an accurate list of available runners.
- Move all Action dockerfiles to one folder
- remove useless `runner` input for e2e test.
- update workflow option version

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This is a configuration change for the CI linter. The correctness will
be verified by `actionlint` running in CI on subsequent pull requests.

- vLLM version: v0.15.0
- vLLM main:
vllm-project/vllm@d7e17aa

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Signed-off-by: momochenchuw <chenchuw@huawei.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
### What this PR does / why we need it?

- This PR removes several self-hosted runner labels from the
`actionlint.yaml` configuration file. These runners are likely no longer
in use, so this change cleans up the configuration and ensures
`actionlint` has an accurate list of available runners.
- Move all Action dockerfiles to one folder
- remove useless `runner` input for e2e test.
- update workflow option version

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This is a configuration change for the CI linter. The correctness will
be verified by `actionlint` running in CI on subsequent pull requests.

- vLLM version: v0.15.0
- vLLM main:
vllm-project/vllm@d7e17aa

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241 pushed a commit to maoxx241/vllm-ascend that referenced this pull request Mar 2, 2026
### What this PR does / why we need it?

- This PR removes several self-hosted runner labels from the
`actionlint.yaml` configuration file. These runners are likely no longer
in use, so this change cleans up the configuration and ensures
`actionlint` has an accurate list of available runners.
- Move all Action dockerfiles to one folder
- remove useless `runner` input for e2e test.
- update workflow option version

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This is a configuration change for the CI linter. The correctness will
be verified by `actionlint` running in CI on subsequent pull requests.

- vLLM version: v0.15.0
- vLLM main:
vllm-project/vllm@d7e17aa

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
### What this PR does / why we need it?

- This PR removes several self-hosted runner labels from the
`actionlint.yaml` configuration file. These runners are likely no longer
in use, so this change cleans up the configuration and ensures
`actionlint` has an accurate list of available runners.
- Move all Action dockerfiles to one folder
- remove useless `runner` input for e2e test.
- update workflow option version

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This is a configuration change for the CI linter. The correctness will
be verified by `actionlint` running in CI on subsequent pull requests.

- vLLM version: v0.15.0
- vLLM main:
vllm-project/vllm@d7e17aa

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 7, 2026
### What this PR does / why we need it?

- This PR removes several self-hosted runner labels from the
`actionlint.yaml` configuration file. These runners are likely no longer
in use, so this change cleans up the configuration and ensures
`actionlint` has an accurate list of available runners.
- Move all Action dockerfiles to one folder
- remove useless `runner` input for e2e test.
- update workflow option version

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

This is a configuration change for the CI linter. The correctness will
be verified by `actionlint` running in CI on subsequent pull requests.

- vLLM version: v0.15.0
- vLLM main:
vllm-project/vllm@d7e17aa

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant