[v0.13.0][Eagle3]Extend PR #5786 to eagle3#6443
Merged
wangxiyuan merged 1 commit intovllm-project:releases/v0.13.0from Jan 30, 2026
Merged
[v0.13.0][Eagle3]Extend PR #5786 to eagle3#6443wangxiyuan merged 1 commit intovllm-project:releases/v0.13.0from
wangxiyuan merged 1 commit intovllm-project:releases/v0.13.0from
Conversation
Signed-off-by: Angazenn <supperccell@163.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request extends a feature previously specific to the 'mtp' speculative decoding method to be applicable to other methods like 'eagle3', particularly in scenarios involving prefill/decode disaggregation and asynchronous scheduling. The changes in vllm_ascend/patch/worker/patch_model_runner.py and vllm_ascend/platform.py correctly generalize the logic by removing the explicit check for method == 'mtp'. This allows the necessary patch for handling draft tokens in async scheduling to be applied for any speculative decoding method when the required conditions are met. The changes are logical and align with the stated goal of the PR. I don't see any issues with the proposed changes.
starmountain1997
pushed a commit
to starmountain1997/vllm-ascend
that referenced
this pull request
Jan 31, 2026
…6443) ### What this PR does / why we need it? This PR extends vllm-project#5786 to eagle3 spec decode when used with pd-disaggregation + async-scheduling. Signed-off-by: Angazenn <supperccell@163.com>
SkychenLee
pushed a commit
to SkychenLee/vllm-ascend
that referenced
this pull request
Jan 31, 2026
…6443) ### What this PR does / why we need it? This PR extends vllm-project#5786 to eagle3 spec decode when used with pd-disaggregation + async-scheduling. Signed-off-by: Angazenn <supperccell@163.com> Signed-off-by: l00832868 <litianchen2@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR extends #5786 to eagle3 spec decode when used with pd-disaggregation + async-scheduling.
Does this PR introduce any user-facing change?
How was this patch tested?