Skip to content

[0.13.0][CI]fix for CI lint#6093

Merged
wangxiyuan merged 1 commit intovllm-project:releases/v0.13.0from
MrZ20:fix-lint
Jan 21, 2026
Merged

[0.13.0][CI]fix for CI lint#6093
wangxiyuan merged 1 commit intovllm-project:releases/v0.13.0from
MrZ20:fix-lint

Conversation

@MrZ20
Copy link
Copy Markdown
Contributor

@MrZ20 MrZ20 commented Jan 21, 2026

What this PR does / why we need it?

fix lint errors on CI

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: MrZ20 <2609716663@qq.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses linting errors in the CI pipeline. The changes involve minor formatting adjustments to improve code readability, specifically focusing on line breaks and spacing within the vllm_ascend/distributed/kvpool/ directory. There are a few high severity issues identified that need to be addressed.

Comment on lines +469 to +470
finished_req_ids,
meta # type: ignore[union-attr]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

high: Consistent formatting improves readability. Add a line break after the first argument to align with the formatting used elsewhere in the file.

            self.get_and_clear_finished_requests(
                finished_req_ids,
                meta  # type: ignore[union-attr]

@wangxiyuan wangxiyuan merged commit b7bb41e into vllm-project:releases/v0.13.0 Jan 21, 2026
7 of 8 checks passed
845473182 pushed a commit to 845473182/vllm-ascend that referenced this pull request Jan 22, 2026
…lm-ascend into FIA_v0.13.0

* 'releases/v0.13.0' of https://github.com/vllm-project/vllm-ascend:
  [0.13.0][Doc] Supplement PD separation parameters of DeepSeek V3.1 (vllm-project#6054)
  [EPLB][Bugfix][v0.13.0] Incorporate the warm up of the EPLB into the profile run. (vllm-project#6099)
  [EPLB][Bugfix] Dispatch Allgather use log2phy if enable eplb (vllm-project#5933) (vllm-project#6016)
  [0.13.0][CI]fix for CI lint (vllm-project#6093)
  [0.13.0][cherry-pick][bugfix] fix the complex and potentially problematic generate_kv_idx. (vllm-project#5955)
@MrZ20 MrZ20 deleted the fix-lint branch January 22, 2026 07:27
starmountain1997 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Jan 31, 2026
### What this PR does / why we need it?
fix lint errors on CI

Signed-off-by: MrZ20 <2609716663@qq.com>
tangtiangu pushed a commit to tangtiangu/jiusi-vllm-ascend that referenced this pull request Feb 24, 2026
### What this PR does / why we need it?
fix lint errors on CI

Signed-off-by: MrZ20 <2609716663@qq.com>
tangtiangu pushed a commit to tangtiangu/jiusi-vllm-ascend that referenced this pull request Feb 24, 2026
### What this PR does / why we need it?
fix lint errors on CI

Signed-off-by: MrZ20 <2609716663@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants