[0.13.0][cherry-pick][bugfix] fix bug of triton mrope#6090
Closed
ichaoren wants to merge 1 commit intovllm-project:releases/v0.13.0from
Closed
[0.13.0][cherry-pick][bugfix] fix bug of triton mrope#6090ichaoren wants to merge 1 commit intovllm-project:releases/v0.13.0from
ichaoren wants to merge 1 commit intovllm-project:releases/v0.13.0from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request refactors the AscendMRotaryEmbedding class to conditionally use Triton's mrope implementation. This involves moving the forward_triton logic into a dedicated method and guarding its invocation with a HAS_TRITON check. This improves modularity and handles the dependency on Triton more gracefully. However, a potential issue related to state management in the forward_triton method has been identified.
Signed-off-by: ichaoren <36871991+ichaoren@users.noreply.github.com>
ichaoren
force-pushed
the
releases/v0.13.0
branch
from
d81bd48 to
dce5c08
Compare
Collaborator
|
replace by this one #6074 |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
fix pr: #5827
keep same with main branch.
Does this PR introduce any user-facing change?
How was this patch tested?