[0.13.0][cherry-pick][bugfix] fix bug of triton mrope#6009
Merged
yiz-liu merged 1 commit intovllm-project:releases/v0.13.0from Jan 20, 2026
Merged
[0.13.0][cherry-pick][bugfix] fix bug of triton mrope#6009yiz-liu merged 1 commit intovllm-project:releases/v0.13.0from
yiz-liu merged 1 commit intovllm-project:releases/v0.13.0from
Conversation
ichaoren
force-pushed
the
releases/v0.13.0
branch
from
0421324 to
113bbd0
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a bug in Triton MROPE and align the code with the main branch. The changes refactor the AscendMRotaryEmbedding class, including moving the forward_triton method and updating the condition to use it. However, the review identified two critical issues. First, the einops import was removed, but the library is still used elsewhere in the file, which will lead to a runtime error. Second, the new implementation of forward_triton contains redundant and confusing logic for calculating cos and sin values. I've provided suggestions to fix these issues.
ichaoren
force-pushed
the
releases/v0.13.0
branch
from
d5318d2 to
e038f82
Compare
Signed-off-by: ichaoren <fengjian5500@163.com>
ichaoren
force-pushed
the
releases/v0.13.0
branch
from
e038f82 to
ec86f5d
Compare
wangxiyuan
changed the title
wangxiyuan
changed the title
yiz-liu
added
ready
845473182
pushed a commit
to 845473182/vllm-ascend
that referenced
this pull request
Jan 21, 2026
…lm-ascend into FIA_v0.13.0 * 'releases/v0.13.0' of https://github.com/vllm-project/vllm-ascend: [0.13.0][Bugfix] Fix setting of `speculative_config.enforce_eager` for dsv32 (vllm-project#5958) [v0.13.0][Bugfix] Fix XliteModelRunner init failed when aclgraph is enabled (vllm-project#5887) [0.13.0][Bugfix] Fixed an problem related to embeddings sharing (vllm-project#5972) [Bugfix]Fixed precision issues caused by pooled request pooling (vllm-project#6057) [0.13.0][Bugfix] fix pcp aclgraph qwen FIA bug (vllm-project#6038) [0.13.0][cherry-pick][bugfix] fix bug of triton mrope (vllm-project#6009) 【0.13.0】【bugfix】Resolved memory deallocation failure in the pooling layer under re-computation workloads. (vllm-project#6056)
shaopeng-666
added a commit
to shaopeng-666/vllm-ascend
that referenced
this pull request
Jan 21, 2026
…roject#6009)" This reverts commit 18eec9d.
shaopeng-666
added a commit
to shaopeng-666/vllm-ascend
that referenced
this pull request
Jan 21, 2026
…roject#6009)" This reverts commit 18eec9d. Signed-off-by: 李少鹏 <lishaopeng21@huawei.com>
yiz-liu
pushed a commit
that referenced
this pull request
Jan 21, 2026
Reverts #6009 Signed-off-by: 李少鹏 <lishaopeng21@huawei.com>
starmountain1997
pushed a commit
to starmountain1997/vllm-ascend
that referenced
this pull request
Jan 31, 2026
) ### What this PR does / why we need it? fix pr: [5827](vllm-project#5827) keep same with main branch. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Signed-off-by: ichaoren <fengjian5500@163.com>
starmountain1997
pushed a commit
to starmountain1997/vllm-ascend
that referenced
this pull request
Jan 31, 2026
…project#6075) Reverts vllm-project#6009 Signed-off-by: 李少鹏 <lishaopeng21@huawei.com>
tangtiangu
pushed a commit
to tangtiangu/jiusi-vllm-ascend
that referenced
this pull request
Feb 24, 2026
) ### What this PR does / why we need it? fix pr: [5827](vllm-project#5827) keep same with main branch. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Signed-off-by: ichaoren <fengjian5500@163.com>
tangtiangu
pushed a commit
to tangtiangu/jiusi-vllm-ascend
that referenced
this pull request
Feb 24, 2026
…project#6075) Reverts vllm-project#6009 Signed-off-by: 李少鹏 <lishaopeng21@huawei.com>
tangtiangu
pushed a commit
to tangtiangu/jiusi-vllm-ascend
that referenced
this pull request
Feb 24, 2026
) ### What this PR does / why we need it? fix pr: [5827](vllm-project#5827) keep same with main branch. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Signed-off-by: ichaoren <fengjian5500@163.com>
tangtiangu
pushed a commit
to tangtiangu/jiusi-vllm-ascend
that referenced
this pull request
Feb 24, 2026
…project#6075) Reverts vllm-project#6009 Signed-off-by: 李少鹏 <lishaopeng21@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
fix pr: 5827
keep same with main branch.
Does this PR introduce any user-facing change?
How was this patch tested?