[Main2Main] Upgrade vllm commit to 0122#5985
[Main2Main] Upgrade vllm commit to 0122#5985Meihan-chen wants to merge 10 commits intovllm-project:mainfrom
Conversation
Meihan-chen
requested review from
LCAIZJ,
MengqingCao,
Yikun,
wangxiyuan and
weijinqian0
as code owners
github-actions
bot
added
documentation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the vLLM dependency to a newer commit. The changes primarily involve updating import paths to align with refactoring in the upstream vLLM repository. Conditional imports based on vllm_version_is are used to maintain compatibility. The modifications appear correct and consistent with the goal of the dependency upgrade. I have not identified any critical or high-severity issues in these changes.
Meihan-chen
force-pushed
the
main0119
branch
5 times, most recently
from
1df3b81 to
b73938e
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Meihan-chen
force-pushed
the
main0119
branch
2 times, most recently
from
15f3ddd to
ee1bfa2
Compare
Meihan-chen
changed the title
Meihan-chen
force-pushed
the
main0119
branch
2 times, most recently
from
0e548c7 to
d7b48e2
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: wjunLu <wjunlu217@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Meihan-chen
changed the title
Meihan-chen
force-pushed
the
main0119
branch
6 times, most recently
from
fec972c to
967c4d9
Compare
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
3 participants
What this PR does / why we need it?
Modify import paths due to the refactors：
[Model Runner V2] Refactor Sampler vllm#32245
[4/N][Attention] Move MLA common to model_executor vllm#32060
Test result: https://github.com/vllm-project/vllm-ascend/actions/runs/21034239336/job/60490156965?pr=5913
Fix
WorkerProc.__init__() missing 1 required positional argument: 'is_driver_worker'due to [TPU][Core] Enable Pipeline Parallelism on TPU backend vllm#28506Does this PR introduce any user-facing change?
How was this patch tested?