[Lint]Style: Convert `vllm-ascend/` to ruff format(Batch #3) by MrZ20 · Pull Request #5978 · vllm-project/vllm-ascend

MrZ20 · 2026-01-18T08:24:27Z

What this PR does / why we need it?

Scope of Changes:

File Path
`vllm_ascend/attention/mla_v1.py`
`vllm_ascend/attention/sfa_v1.py`
`vllm_ascend/core/recompute_scheduler.py`
`vllm_ascend/core/scheduler_dynamic_batch.py`
`vllm_ascend/distributed/device_communicators/npu_communicator.py`
`vllm_ascend/distributed/device_communicators/pyhccl.py`
`vllm_ascend/distributed/device_communicators/pyhccl_wrapper.py`

Does this PR introduce any user-facing change?

How was this patch tested?

vLLM version: v0.13.0
vLLM main: vllm-project/vllm@2c24bc6

github-actions · 2026-01-18T08:24:43Z

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

A PR should do only one thing, smaller PRs enable faster reviews.
Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

gemini-code-assist

Code Review

This pull request continues the effort of applying ruff format to the vllm-ascend/ directory, targeting a new batch of files. The changes are purely stylistic and include reformatting long lines, updating type hints to modern syntax (e.g., using | for Optional), and removing unused imports. These modifications enhance code readability and consistency. The changes are correct and align with the PR's objective. I have no further comments.

github-actions · 2026-01-19T01:26:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2026-01-21T01:16:05Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2026-01-21T02:47:52Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2026-01-24T12:45:03Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: MrZ20 <2609716663@qq.com>

Signed-off-by: MrZ20 <2609716663@qq.com> manual Signed-off-by: MrZ20 <2609716663@qq.com> fix Signed-off-by: MrZ20 <2609716663@qq.com>

Signed-off-by: MrZ20 <2609716663@qq.com>

…) (vllm-project#5978) ### What this PR does / why we need it? **Scope of Changes**: | File Path | | :--- | | `vllm_ascend/attention/mla_v1.py` | | `vllm_ascend/attention/sfa_v1.py` | | `vllm_ascend/core/recompute_scheduler.py` | | `vllm_ascend/core/scheduler_dynamic_batch.py` | | `vllm_ascend/distributed/device_communicators/npu_communicator.py` | | `vllm_ascend/distributed/device_communicators/pyhccl.py` | | `vllm_ascend/distributed/device_communicators/pyhccl_wrapper.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Co-authored-by: Soren <user@SorendeMac-mini.local>

…) (vllm-project#5978) ### What this PR does / why we need it? **Scope of Changes**: | File Path | | :--- | | `vllm_ascend/attention/mla_v1.py` | | `vllm_ascend/attention/sfa_v1.py` | | `vllm_ascend/core/recompute_scheduler.py` | | `vllm_ascend/core/scheduler_dynamic_batch.py` | | `vllm_ascend/distributed/device_communicators/npu_communicator.py` | | `vllm_ascend/distributed/device_communicators/pyhccl.py` | | `vllm_ascend/distributed/device_communicators/pyhccl_wrapper.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Co-authored-by: Soren <user@SorendeMac-mini.local> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>

…) (vllm-project#5978) ### What this PR does / why we need it? **Scope of Changes**: | File Path | | :--- | | `vllm_ascend/attention/mla_v1.py` | | `vllm_ascend/attention/sfa_v1.py` | | `vllm_ascend/core/recompute_scheduler.py` | | `vllm_ascend/core/scheduler_dynamic_batch.py` | | `vllm_ascend/distributed/device_communicators/npu_communicator.py` | | `vllm_ascend/distributed/device_communicators/pyhccl.py` | | `vllm_ascend/distributed/device_communicators/pyhccl_wrapper.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Co-authored-by: Soren <user@SorendeMac-mini.local>

…) (vllm-project#5978) ### What this PR does / why we need it? **Scope of Changes**: | File Path | | :--- | | `vllm_ascend/attention/mla_v1.py` | | `vllm_ascend/attention/sfa_v1.py` | | `vllm_ascend/core/recompute_scheduler.py` | | `vllm_ascend/core/scheduler_dynamic_batch.py` | | `vllm_ascend/distributed/device_communicators/npu_communicator.py` | | `vllm_ascend/distributed/device_communicators/pyhccl.py` | | `vllm_ascend/distributed/device_communicators/pyhccl_wrapper.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Co-authored-by: Soren <user@SorendeMac-mini.local> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>

…) (vllm-project#5978) ### What this PR does / why we need it? **Scope of Changes**: | File Path | | :--- | | `vllm_ascend/attention/mla_v1.py` | | `vllm_ascend/attention/sfa_v1.py` | | `vllm_ascend/core/recompute_scheduler.py` | | `vllm_ascend/core/scheduler_dynamic_batch.py` | | `vllm_ascend/distributed/device_communicators/npu_communicator.py` | | `vllm_ascend/distributed/device_communicators/pyhccl.py` | | `vllm_ascend/distributed/device_communicators/pyhccl_wrapper.py` | ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@2c24bc6 --------- Signed-off-by: MrZ20 <2609716663@qq.com> Co-authored-by: Soren <user@SorendeMac-mini.local>

MrZ20 requested review from LCAIZJ, MengqingCao, wangxiyuan, weijinqian0 and zzzzwwjj as code owners January 18, 2026 08:24

github-actions bot added the module:core label Jan 18, 2026

gemini-code-assist bot reviewed Jan 18, 2026

View reviewed changes

MrZ20 closed this Jan 18, 2026

MrZ20 reopened this Jan 19, 2026

github-actions bot added the merge-conflicts label Jan 19, 2026

MrZ20 force-pushed the lint-ascend-2 branch from 58c93c5 to f187edc Compare January 19, 2026 01:56

github-actions bot removed the merge-conflicts label Jan 19, 2026

MrZ20 force-pushed the lint-ascend-2 branch from 56f7bfd to a88d7d1 Compare January 19, 2026 04:00

vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Jan 19, 2026

MrZ20 mentioned this pull request Jan 19, 2026

[RFC]: Gradual migration of linting and formatting to Ruff #5845

Open

MrZ20 changed the title ~~[Lint]Style: Convert vllm-ascend/ to ruff format(Batch #3)~~ [Lint]Style: Convert vllm-ascend/ to ruff format(Batch #3) Jan 19, 2026

MrZ20 force-pushed the lint-ascend-2 branch 2 times, most recently from 1869a6b to 193584f Compare January 20, 2026 13:09

github-actions bot added the merge-conflicts label Jan 21, 2026

MrZ20 force-pushed the lint-ascend-2 branch from 193584f to 69b49c0 Compare January 21, 2026 02:34

github-actions bot removed the merge-conflicts label Jan 21, 2026

MrZ20 force-pushed the lint-ascend-2 branch from 69b49c0 to 41cbce3 Compare January 21, 2026 02:40

github-actions bot added the merge-conflicts label Jan 21, 2026

Potabk removed ready read for review ready-for-test start test by label for PR labels Jan 21, 2026

MrZ20 force-pushed the lint-ascend-2 branch from 41cbce3 to e608a90 Compare January 23, 2026 07:23

github-actions bot removed the merge-conflicts label Jan 23, 2026

MrZ20 force-pushed the lint-ascend-2 branch 3 times, most recently from e64801d to 4b6e1a4 Compare January 23, 2026 14:59

github-actions bot added the merge-conflicts label Jan 24, 2026

MrZ20 and others added 6 commits January 24, 2026 20:47

auto

ed7f73d

Signed-off-by: MrZ20 <2609716663@qq.com>

manual

ec31f3d

Signed-off-by: MrZ20 <2609716663@qq.com>

auto

93812d6

Signed-off-by: MrZ20 <2609716663@qq.com> manual Signed-off-by: MrZ20 <2609716663@qq.com> fix Signed-off-by: MrZ20 <2609716663@qq.com>

fix

7e5bc80

Signed-off-by: MrZ20 <2609716663@qq.com>

update

6b42c60

Signed-off-by: MrZ20 <2609716663@qq.com>

modify

49a2323

Signed-off-by: MrZ20 <2609716663@qq.com>

MrZ20 force-pushed the lint-ascend-2 branch from 4b6e1a4 to 49a2323 Compare January 24, 2026 12:52

github-actions bot removed the merge-conflicts label Jan 24, 2026

wangxiyuan merged commit 7faa687 into vllm-project:main Jan 24, 2026
20 checks passed

MrZ20 deleted the lint-ascend-2 branch January 25, 2026 05:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lint]Style: Convert `vllm-ascend/` to ruff format(Batch #3)#5978

[Lint]Style: Convert `vllm-ascend/` to ruff format(Batch #3)#5978
wangxiyuan merged 6 commits intovllm-project:mainfrom
MrZ20:lint-ascend-2

MrZ20 commented Jan 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MrZ20 commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MrZ20 commented Jan 18, 2026 •

edited

Loading